[Feature/Extensions] Profile detector #882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
…oject/anomaly-detection into feature/extensions
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## feature/extensions #882 +/- ##
========================================================
- Coverage 34.95% 34.50% -0.45%
+ Complexity 1888 1867 -21
========================================================
Files 300 300
Lines 17863 17875 +12
Branches 1862 1862
========================================================
- Hits 6244 6168 -76
- Misses 11171 11260 +89
+ Partials 448 447 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…oject/anomaly-detection into feature/extensions
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
joshpalis
requested changes
Apr 28, 2023
src/main/java/org/opensearch/ad/transport/RCFPollingTransportAction.java
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/transport/RCFPollingTransportAction.java
Show resolved
Hide resolved
dbwiddis
reviewed
Apr 28, 2023
Signed-off-by: Varun Jain <[email protected]>
joshpalis
approved these changes
Apr 28, 2023
Signed-off-by: Varun Jain <[email protected]>
owaiskazi19
requested changes
Apr 28, 2023
There was a problem hiding this comment.
Will wait for @vibrantvarun to paste the API response of all the profile detector APIs on the issue
|
All Api's are tested and responses has been added in the comments of the issue. |
…oject/anomaly-detection into feature/extensions
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
2 tasks
Signed-off-by: Varun Jain <[email protected]>
owaiskazi19
requested changes
May 1, 2023
| import org.opensearch.ad.transport.StopDetectorTransportAction; | ||
| import org.opensearch.ad.transport.ValidateAnomalyDetectorAction; | ||
| import org.opensearch.ad.transport.ValidateAnomalyDetectorTransportAction; | ||
| import org.opensearch.ad.transport.*; |
| new ArrayList<>(List.of(new ADTaskProfileNodeResponse(sdkClusterService.localNode(), adTaskProfile, remoteAdVersion))), | ||
| new ArrayList<>() | ||
| ) | ||
| ); |
There was a problem hiding this comment.
I see these new changes are added now and were not there before because all of the APIs of profile detectors were not tested. Let's test all the APIs from next time to avoid such misses.
There was a problem hiding this comment.
Yes, I acknowledge that.
Signed-off-by: Varun Jain <[email protected]>
owaiskazi19
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Profile Detector API's for extensions
Issues Resolved
381
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.