Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Forward port 2.x] Fixing dls/fls logic around numeric aggregations #800

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented Feb 2, 2023

Forward port 44de1c4 from #787

Signed-off-by: Kaituo Li [email protected]

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kaituo kaituo requested review from a team, ylwu-amzn and amitgalitz February 2, 2023 23:38
@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2023

Codecov Report

Merging #800 (04af7d5) into 2.x (ca746f5) will increase coverage by 0.01%.
The diff coverage is 69.17%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #800      +/-   ##
============================================
+ Coverage     79.58%   79.59%   +0.01%     
- Complexity     4317     4332      +15     
============================================
  Files           303      307       +4     
  Lines         18023    18144     +121     
  Branches       1914     1909       -5     
============================================
+ Hits          14343    14442      +99     
- Misses         2772     2789      +17     
- Partials        908      913       +5     
Flag Coverage Δ
plugin 79.59% <69.17%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...est/handler/IndexAnomalyDetectorActionHandler.java 100.00% <ø> (ø)
.../ad/rest/handler/ModelValidationActionHandler.java 0.00% <0.00%> (ø)
.../handler/ValidateAnomalyDetectorActionHandler.java 100.00% <ø> (ø)
...c/main/java/org/opensearch/ad/util/ParseUtils.java 77.85% <ø> (ø)
...rc/main/java/org/opensearch/ad/util/Throttler.java 80.00% <0.00%> (-20.00%) ⬇️
...rg/opensearch/ad/AnomalyDetectorProfileRunner.java 67.95% <53.84%> (-0.41%) ⬇️
...a/org/opensearch/ad/util/SafeSecurityInjector.java 57.57% <57.57%> (ø)
...va/org/opensearch/ad/AnomalyDetectorJobRunner.java 80.50% <61.90%> (+0.19%) ⬆️
...org/opensearch/ad/util/ADSafeSecurityInjector.java 72.41% <72.41%> (ø)
...main/java/org/opensearch/ad/util/SecurityUtil.java 87.50% <87.50%> (ø)
... and 23 more

@kaituo kaituo merged commit 56110b7 into opensearch-project:2.x Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants