-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically set bwc current version from properties version #778
Dynamically set bwc current version from properties version #778
Conversation
Signed-off-by: Zelin Hao <[email protected]>
@kaituo @amitgalitz Are we good to merge this and backport to 2.5 branch? I don't think the CI would pass as we don't have 2.6.0 build tools yet. |
Is it needed for 2.5 branch and release? |
Oh right. This might not be that urgent as it should be good for 2.5 branch right now. I'm OK to let it stay until release for this PR. Thanks! |
Codecov Report
@@ Coverage Diff @@
## 2.x #778 +/- ##
============================================
+ Coverage 79.11% 79.75% +0.64%
- Complexity 4245 4329 +84
============================================
Files 301 303 +2
Lines 17872 18023 +151
Branches 1897 1914 +17
============================================
+ Hits 14139 14374 +235
+ Misses 2832 2743 -89
- Partials 901 906 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Are we good to merge this PR now? Thanks! @amitgalitz @kaituo |
@zelinh merged. Could you send a PR to 2.5 and main branch? |
Signed-off-by: Zelin Hao [email protected]
Description
As currently 2.x is bumped to 2.6, we should have also increment the version for bwc tests.
Instead, this PR is to dynamically set bwc current version from properties version so we don't have to change this version every time we do version increment.
Will also need to backport this PR to 2.5 branch.
Issues Resolved
Part of opensearch-project/opensearch-build#2870
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.