Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically set bwc current version from properties version #778

Merged
merged 1 commit into from
Feb 2, 2023

Conversation

zelinh
Copy link
Member

@zelinh zelinh commented Jan 9, 2023

Signed-off-by: Zelin Hao [email protected]

Description

As currently 2.x is bumped to 2.6, we should have also increment the version for bwc tests.
Instead, this PR is to dynamically set bwc current version from properties version so we don't have to change this version every time we do version increment.

Will also need to backport this PR to 2.5 branch.

Issues Resolved

Part of opensearch-project/opensearch-build#2870

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@zelinh zelinh requested a review from a team January 9, 2023 23:44
@zelinh
Copy link
Member Author

zelinh commented Jan 9, 2023

@kaituo @amitgalitz Are we good to merge this and backport to 2.5 branch? I don't think the CI would pass as we don't have 2.6.0 build tools yet.

@amitgalitz
Copy link
Member

@kaituo @amitgalitz Are we good to merge this and backport to 2.5 branch? I don't think the CI would pass as we don't have 2.6.0 build tools yet.

Is it needed for 2.5 branch and release?

@zelinh
Copy link
Member Author

zelinh commented Jan 9, 2023

@kaituo @amitgalitz Are we good to merge this and backport to 2.5 branch? I don't think the CI would pass as we don't have 2.6.0 build tools yet.

Is it needed for 2.5 branch and release?

Oh right. This might not be that urgent as it should be good for 2.5 branch right now. I'm OK to let it stay until release for this PR. Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Merging #778 (a41f800) into 2.x (867c1b3) will increase coverage by 0.64%.
The diff coverage is 75.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x     #778      +/-   ##
============================================
+ Coverage     79.11%   79.75%   +0.64%     
- Complexity     4245     4329      +84     
============================================
  Files           301      303       +2     
  Lines         17872    18023     +151     
  Branches       1897     1914      +17     
============================================
+ Hits          14139    14374     +235     
+ Misses         2832     2743      -89     
- Partials        901      906       +5     
Flag Coverage Δ
plugin 79.75% <75.94%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...in/java/org/opensearch/ad/constant/CommonName.java 75.00% <ø> (ø)
.../java/org/opensearch/ad/model/AnomalyDetector.java 92.30% <ø> (+0.38%) ⬆️
...a/org/opensearch/ad/rest/AbstractSearchAction.java 57.50% <0.00%> (+18.51%) ⬆️
...arch/ad/rest/RestExecuteAnomalyDetectorAction.java 26.82% <ø> (+0.63%) ⬆️
...nsearch/ad/rest/RestSearchAnomalyResultAction.java 23.80% <0.00%> (ø)
...rch/ad/transport/AnomalyResultTransportAction.java 80.64% <0.00%> (-0.24%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 78.32% <28.57%> (+1.42%) ⬆️
...opensearch/ad/ratelimit/EntityColdStartWorker.java 81.57% <66.66%> (-18.43%) ⬇️
...ava/org/opensearch/ad/task/ADTaskCacheManager.java 88.73% <66.66%> (-0.58%) ⬇️
...va/org/opensearch/ad/AnomalyDetectorJobRunner.java 80.30% <68.96%> (+16.12%) ⬆️
... and 26 more

@zelinh
Copy link
Member Author

zelinh commented Jan 24, 2023

Are we good to merge this PR now? Thanks! @amitgalitz @kaituo

@kaituo
Copy link
Collaborator

kaituo commented Feb 2, 2023

@zelinh merged. Could you send a PR to 2.5 and main branch?

@kaituo kaituo merged commit ca746f5 into opensearch-project:2.x Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants