Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/extensions] Validate Detector Action Handle request #742

Merged
merged 9 commits into from
Dec 5, 2022
Merged

[Feature/extensions] Validate Detector Action Handle request #742

merged 9 commits into from
Dec 5, 2022

Conversation

vibrantvarun
Copy link
Member

@vibrantvarun vibrantvarun commented Dec 1, 2022

Signed-off-by: Varun Jain [email protected]

Description

Template of Handle Validate Detector request in RestValidateDetectorAction

Part of Issue:
opensearch-project/opensearch-sdk-java#222
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@vibrantvarun vibrantvarun requested a review from a team December 1, 2022 01:36
@owaiskazi19 owaiskazi19 changed the title Validate Detector Action Handle request [Feature/extensions] Validate Detector Action Handle request Dec 1, 2022
@owaiskazi19
Copy link
Member

Is this PR a template for the logic of ValidateDetector since there's no request call for the same?

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start. Can we use the new routeHandler() syntax?

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shadowing is not a good thing.

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2022

Codecov Report

Merging #742 (cd105d9) into feature/extensions (71010ca) will decrease coverage by 0.07%.
The diff coverage is 4.87%.

Impacted file tree graph

@@                   Coverage Diff                    @@
##             feature/extensions     #742      +/-   ##
========================================================
- Coverage                 53.33%   53.25%   -0.08%     
- Complexity                 2658     2662       +4     
========================================================
  Files                       291      291              
  Lines                     16061    16097      +36     
  Branches                   1686     1689       +3     
========================================================
+ Hits                       8566     8573       +7     
- Misses                     6877     6908      +31     
+ Partials                    618      616       -2     
Flag Coverage Δ
plugin 53.25% <4.87%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...va/org/opensearch/ad/AnomalyDetectorExtension.java 0.00% <0.00%> (ø)
...opensearch/ad/rest/RestValidateDetectorAction.java 0.00% <0.00%> (ø)
.../java/org/opensearch/ad/util/RestHandlerUtils.java 66.15% <100.00%> (+0.52%) ⬆️
...ava/org/opensearch/ad/model/TimeConfiguration.java 100.00% <0.00%> (ø)
...c/main/java/org/opensearch/ad/util/ParseUtils.java 60.57% <0.00%> (+0.14%) ⬆️
...opensearch/ad/indices/AnomalyDetectionIndices.java 40.21% <0.00%> (+0.21%) ⬆️
.../main/java/org/opensearch/ad/ml/CheckpointDao.java 70.19% <0.00%> (+0.64%) ⬆️
...ain/java/org/opensearch/ad/model/ModelProfile.java 68.75% <0.00%> (+2.08%) ⬆️

@dbwiddis dbwiddis merged commit bda73f8 into opensearch-project:feature/extensions Dec 5, 2022
@vibrantvarun vibrantvarun deleted the feature/extensions branch December 5, 2022 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants