-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature/extensions] Validate Detector Action Handle request #742
[Feature/extensions] Validate Detector Action Handle request #742
Conversation
src/main/java/org/opensearch/ad/rest/RestValidateDetectorAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/rest/RestValidateDetectorAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/rest/RestValidateDetectorAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/rest/RestValidateDetectorAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/rest/RestValidateDetectorAction.java
Outdated
Show resolved
Hide resolved
Is this PR a template for the logic of ValidateDetector since there's no request call for the same? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start. Can we use the new routeHandler()
syntax?
src/main/java/org/opensearch/ad/rest/RestValidateDetectorAction.java
Outdated
Show resolved
Hide resolved
src/main/java/org/opensearch/ad/rest/RestValidateDetectorAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shadowing is not a good thing.
src/main/java/org/opensearch/ad/rest/RestValidateDetectorAction.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Codecov Report
@@ Coverage Diff @@
## feature/extensions #742 +/- ##
========================================================
- Coverage 53.33% 53.25% -0.08%
- Complexity 2658 2662 +4
========================================================
Files 291 291
Lines 16061 16097 +36
Branches 1686 1689 +3
========================================================
+ Hits 8566 8573 +7
- Misses 6877 6908 +31
+ Partials 618 616 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain [email protected]
Description
Template of Handle Validate Detector request in RestValidateDetectorAction
Part of Issue:
opensearch-project/opensearch-sdk-java#222
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.