Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding windows and macos CI #701

Closed
wants to merge 3 commits into from

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky [email protected]

Description

adding windows and macos to CI runs

Issues Resolved

resolves #274

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <[email protected]>
@amitgalitz amitgalitz requested a review from a team October 26, 2022 22:07
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 2.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Oct 26, 2022
@amitgalitz amitgalitz marked this pull request as draft October 26, 2022 22:35
@codecov-commenter
Copy link

codecov-commenter commented Oct 26, 2022

Codecov Report

Merging #701 (2c1d5b5) into main (7a05826) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 2c1d5b5 differs from pull request most recent head 12763ed. Consider uploading reports for the commit 12763ed to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #701      +/-   ##
============================================
- Coverage     79.23%   79.21%   -0.02%     
- Complexity     4253     4255       +2     
============================================
  Files           301      301              
  Lines         17872    17872              
  Branches       1897     1897              
============================================
- Hits          14160    14157       -3     
- Misses         2813     2814       +1     
- Partials        899      901       +2     
Flag Coverage Δ
plugin 79.21% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 84.19% <0.00%> (-1.52%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 77.88% <0.00%> (+0.52%) ⬆️

Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
@amitgalitz amitgalitz closed this Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Windows Support
2 participants