Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Github DCO action since DCO runs via Github App now #664

Merged
merged 1 commit into from
Sep 14, 2022

Conversation

owaiskazi19
Copy link
Member

Signed-off-by: Owais Kazi [email protected]

Description

Removed Github DCO action since DCO runs via Github App now.
Updated few comments from ElasticSearch to OpenSearch

Issues Resolved

List any issues this PR will resolve, e.g. Closes [...].

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@owaiskazi19 owaiskazi19 requested review from a team and saratvemulapalli September 8, 2022 22:01
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 2.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Sep 8, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 8, 2022

Codecov Report

Merging #664 (608b11c) into main (19a6c84) will increase coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #664      +/-   ##
============================================
+ Coverage     78.91%   79.22%   +0.30%     
- Complexity     4233     4253      +20     
============================================
  Files           301      301              
  Lines         17872    17872              
  Branches       1897     1897              
============================================
+ Hits          14104    14159      +55     
+ Misses         2868     2813      -55     
  Partials        900      900              
Flag Coverage Δ
plugin 79.22% <ø> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../main/java/org/opensearch/ad/NodeStateManager.java 71.89% <ø> (ø)
...c/main/java/org/opensearch/ad/util/IndexUtils.java 87.87% <ø> (ø)
.../java/org/opensearch/ad/AnomalyDetectorRunner.java 37.64% <0.00%> (-5.89%) ⬇️
...ain/java/org/opensearch/ad/model/ModelProfile.java 69.09% <0.00%> (-3.64%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 77.28% <0.00%> (+0.37%) ⬆️
...rch/ad/transport/AnomalyResultTransportAction.java 80.87% <0.00%> (+0.69%) ⬆️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 92.59% <0.00%> (+2.46%) ⬆️
...va/org/opensearch/ad/feature/SearchFeatureDao.java 86.68% <0.00%> (+3.84%) ⬆️
...c/main/java/org/opensearch/ad/util/ParseUtils.java 77.85% <0.00%> (+3.92%) ⬆️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 86.01% <0.00%> (+4.25%) ⬆️

@amitgalitz
Copy link
Member

@owaiskazi19 missing some context on this, what does it mean that it runs through the Github App now?

@owaiskazi19
Copy link
Member Author

owaiskazi19 commented Sep 14, 2022

@owaiskazi19 missing some context on this, what does it mean that it runs through the Github App now?

Hey @amitgalitz! @opensearch-project has integrated DCO app to run across all the repos. If you see the GH action checks https://github.com/opensearch-project/anomaly-detection/pull/664/checks. You can find DCO app which means we don't have to run the workflow in the repo because it is handled by @opensearch-project across all the repos.
Ref PR on OpenSearch.

@amitgalitz
Copy link
Member

@owaiskazi19 missing some context on this, what does it mean that it runs through the Github App now?

Hey @amitgalitz! @opensearch-project has integrated DCO app to run across all the repos. If you see the GH action checks https://github.com/opensearch-project/anomaly-detection/pull/664/checks. You can find DCO app which means we don't have to run the workflow in the repo because it is handled by @opensearch-project across all the repos. Ref PR on OpenSearch.

got it, thanks for keeping it up to date on AD

@amitgalitz amitgalitz merged commit 397ebcc into opensearch-project:main Sep 14, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 14, 2022
ohltyler pushed a commit that referenced this pull request Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants