Update ingestion #592
Merged
Update ingestion #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #592 +/- ##
============================================
- Coverage 79.03% 78.89% -0.15%
+ Complexity 4209 4201 -8
============================================
Files 296 296
Lines 17686 17686
Branches 1880 1880
============================================
- Hits 13979 13954 -25
- Misses 2808 2838 +30
+ Partials 899 894 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
reviewed
Jun 27, 2022
| hosts=[{'host': URL, 'port': 443}], | ||
| use_ssl=True, | ||
| verify_certs=False, | ||
| http_auth=(USERNAME, PASSWORD), | ||
| http_auth=('admin', 'admin'), |
There was a problem hiding this comment.
You uploaded the wrong file, right?
Signed-off-by: Amit Galitzky <[email protected]>
ylwu-amzn
previously approved these changes
Jun 27, 2022
kaituo
reviewed
Jun 27, 2022
| def main(): | ||
| global client | ||
| for i in range(0, THREADS): | ||
| client.append(create_client(SECURITY, URL)) |
There was a problem hiding this comment.
only saw you used the refactored create_client code, not anything else I sent to you. Does my fix solve the dropping entity issue?
There was a problem hiding this comment.
Yes I actually used the wrong file to ingest data, not the one with adding more retry logic in a loop. It worked for ingesting 1b documents, 7 days of 1440 points a day. I will try using the right file now with more retry logic for 14 days of 1440 points a day
Signed-off-by: Amit Galitzky <[email protected]>
ylwu-amzn
approved these changes
Jun 27, 2022
kaituo
approved these changes
Jun 27, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 0bd6e0e)
amitgalitz
added a commit
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 0bd6e0e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update numpy to fix CVE, upgrade scipy to be compatible with upgraded numpy and upgrade opensearch-py to latest version. Changed accordingly the minimum Python version to 3.8 because of numpy upgrade. Added more retries to handle exceptions during bulk ingestions that would lead to threads being dropped.
Issues Resolved
#590
#591
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.