Disable interpolation in HCAD cold start #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we used interpolation in HCAD cold start for the purpose of efficiency. This caused problems for model accuracy. This PR removes interpolation in the cold start step. Testing done: 1. added unit tests to verify precision boosted. Signed-off-by: Kaituo Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #575 +/- ##
============================================
- Coverage 79.03% 79.00% -0.04%
- Complexity 4203 4204 +1
============================================
Files 296 296
Lines 17679 17682 +3
Branches 1879 1880 +1
============================================
- Hits 13973 13969 -4
- Misses 2806 2813 +7
Partials 900 900
Flags with carried forward coverage won't be shown. Click here to find out more.
|
amitgalitz
reviewed
Jun 20, 2022
amitgalitz
reviewed
Jun 20, 2022
Signed-off-by: Kaituo Li <[email protected]>
amitgalitz
previously approved these changes
Jun 20, 2022
ylwu-amzn
reviewed
Jun 21, 2022
| @@ -258,6 +258,8 @@ private AnomalyDetectorSettings() {} | |||
|
|
|||
| public static final int MAX_IMPUTATION_NEIGHBOR_DISTANCE = 2; | |||
|
|
|||
| public static final boolean ALLOW_INTERPLATION_IN_COLDSTART = false; | |||
There was a problem hiding this comment.
Should we make this as dynamic setting?
Signed-off-by: Kaituo Li <[email protected]>
ylwu-amzn
approved these changes
Jun 22, 2022
amitgalitz
approved these changes
Jun 22, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 22, 2022
* Disable interpolation in HCAD cold start Previously, we used interpolation in HCAD cold start for the purpose of efficiency. This caused problems for model accuracy. This PR removes interpolation in the cold start step. Testing done: 1. added unit tests to verify precision boosted. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 03e04d7)
kaituo
added a commit
that referenced
this pull request
Jun 22, 2022
* Disable interpolation in HCAD cold start Previously, we used interpolation in HCAD cold start for the purpose of efficiency. This caused problems for model accuracy. This PR removes interpolation in the cold start step. Testing done: 1. added unit tests to verify precision boosted. Signed-off-by: Kaituo Li <[email protected]> (cherry picked from commit 03e04d7) Co-authored-by: Kaituo Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, we used interpolation in HCAD cold start for the purpose of efficiency. This caused problems for model accuracy. This PR removes interpolation in the cold start step.
Testing done:
Signed-off-by: Kaituo Li [email protected]
Issues Resolved
#539
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.