[Forward port to 1.3] Use current time as training data end time (#547) #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use current time as training data end time The bug happens because we use job enabled time as training data end time. But if the historical data before that time is deleted or does not exist at all, cold start might never finish. This PR uses current time as the training data end time so that cold start has a chance to succeed later. This PR also removes the code that combines cold start data and existing samples in EntityColdStartWorker because we don't add samples until cold start succeeds. Combining cold start data and existing samples is thus unnecessary. Testing done: 1. manually verified the bug is fixed. 2. fixed all related unit tests. Signed-off-by: Kaituo Li <[email protected]>
kaituo
changed the title
ylwu-amzn
previously approved these changes
May 23, 2022
This commit removes randomization of locale for SimpleDateFormat, instead using explicit locales. The test framework randomizes locales, so the test can be ran with " ./gradlew ':integTest' --tests "org.opensearch.ad.e2e.DetectionResultEvalutationIT.testRestartHCADDetector" -Dtests.seed=3892A75781CC10EC -Dtests.security.manager=false -Dtests.locale=th-TH-u-nu-thai-x-lvariant-TH -Dtests.timezone=America/Merida -Druntime.java=14". This would cause the code to write the data string in thai locale and make bulk api fail with message "failed to parse date field [๒๕๖๕-๐๕-๒๓T๒๐:๕๖:๐๐Z] with format [strict_date_optional_time||epoch_millis]","caused_by":{"type":"date_time_parse_exception".
Signed-off-by: Kaituo Li <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 1.3 #556 +/- ##
============================================
+ Coverage 77.75% 78.02% +0.27%
- Complexity 4114 4134 +20
============================================
Files 296 296
Lines 17682 17680 -2
Branches 1879 1881 +2
============================================
+ Hits 13748 13795 +47
+ Misses 3029 2988 -41
+ Partials 905 897 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ylwu-amzn
approved these changes
May 24, 2022
amitgalitz
approved these changes
May 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The bug happens because we use job enabled time as training data end time. But if the historical data before that time is deleted or does not exist at all, cold start might never finish. This PR uses current time as the training data end time so that cold start has a chance to succeed later. This PR also removes the code that combines cold start data and existing samples in EntityColdStartWorker because we don't add samples until cold start succeeds. Combining cold start data and existing samples is thus unnecessary.
Testing done:
Signed-off-by: Kaituo Li [email protected]
Issues Resolved
#540
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.