bump rcf to 3.0-rc2.1 #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitgalitz
changed the title
opensearch-trigger-bot
bot
added
backport 2.x
infra
Codecov Report
@@ Coverage Diff @@
## main #519 +/- ##
============================================
- Coverage 79.02% 79.00% -0.02%
- Complexity 4195 4203 +8
============================================
Files 296 296
Lines 17663 17681 +18
Branches 1878 1877 -1
============================================
+ Hits 13958 13969 +11
- Misses 2806 2813 +7
Partials 899 899
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kaituo
reviewed
Apr 22, 2022
| assertEquals(30, forest.getForest().getNumberOfTrees()); | ||
| } | ||
|
|
||
| public void testDeserializeTRCFModel() throws Exception { |
There was a problem hiding this comment.
Could you add the test's purpose?
| @@ -1000,4 +1005,77 @@ private double[] getPoint(int dimensions, Random random) { | |||
| } | |||
| return point; | |||
| } | |||
|
|
|||
| public void testDeserializeRCFModelPreINIT() throws Exception { | |||
There was a problem hiding this comment.
are the following 2 tests used for single-stream detector's checkpoints? If so, could you add comments?
kaituo
previously approved these changes
Apr 25, 2022
ylwu-amzn
reviewed
Apr 25, 2022
| @@ -367,7 +367,7 @@ public Collection<Object> createComponents( | |||
| mapper.setSaveExecutorContextEnabled(true); | |||
| mapper.setSaveTreeStateEnabled(true); | |||
| mapper.setPartialTreeStateEnabled(true); | |||
| V1JsonToV2StateConverter converter = new V1JsonToV2StateConverter(); | |||
| V1JsonToV3StateConverter converter = new V1JsonToV3StateConverter(); | |||
There was a problem hiding this comment.
Do we need V2 to V3 converter? How about add some comments to explain what's V1, V2 and V3?
There was a problem hiding this comment.
After testing and looking at RCF code, we don't need a converter between v2 to v3 as that is dealt with accordingly on RCF side. I also added a unit test where we parse a v2 checkpoint with RCF3.0-rc2.1 as a dependency(v3) and we get the same result as we do when parsing with rc1(v2). I'll add some comments explaining v1, v2, v3 in checkPointDAO class.
kaituo
previously approved these changes
May 2, 2022
kaituo
reviewed
May 2, 2022
| @@ -117,6 +117,14 @@ public class CheckpointDao { | |||
|
|
|||
| private Gson gson; | |||
| private RandomCutForestMapper mapper; | |||
|
|
|||
| // For further reference v1, v2 and v3 refer to the different variations of RCF models | |||
| // used by AD. v1 was originally used with the lunch of OS 1.0. We later converted to v2 | |||
kaituo
previously approved these changes
May 2, 2022
ylwu-amzn
previously approved these changes
May 2, 2022
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
ylwu-amzn
approved these changes
May 3, 2022
kaituo
approved these changes
May 3, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 3, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 8227e32)
amitgalitz
added a commit
that referenced
this pull request
May 4, 2022
Signed-off-by: Amit Galitzky <[email protected]> (cherry picked from commit 8227e32)
amitgalitz
added a commit
to amitgalitz/anomaly-detection-1
that referenced
this pull request
May 12, 2022
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
added a commit
that referenced
this pull request
May 13, 2022
Signed-off-by: Amit Galitzky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Galitzky [email protected]
Description
Other manual testing done:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.