Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed rcf jar for 3.0-rc1 and fixed zip fetching for AD and JS #500

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky [email protected]

Description

  1. Removed RCF jars and updated to fetch RCF 3.0-rc1 from maven
  2. Added zip and folder deletion before fetching zips for bwc and integCluster so there isn't multiple zips

I tested with rc1 that there is no bwc issues when creating real time single or multi entity detectors or for historical analysis on single and multi entity detectors.

Issues Resolved

resolves #433

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@amitgalitz amitgalitz requested a review from a team April 13, 2022 18:12
@opensearch-trigger-bot opensearch-trigger-bot bot added backport 1.x infra Changes to infrastructure, testing, CI/CD, pipelines, etc. labels Apr 13, 2022
@amitgalitz amitgalitz requested review from ylwu-amzn and kaituo April 13, 2022 18:14
@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2022

Codecov Report

Merging #500 (908e808) into main (9d44f1b) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #500      +/-   ##
============================================
+ Coverage     78.16%   78.18%   +0.01%     
- Complexity     4159     4160       +1     
============================================
  Files           296      296              
  Lines         17663    17663              
  Branches       1878     1878              
============================================
+ Hits          13807    13809       +2     
+ Misses         2959     2958       -1     
+ Partials        897      896       -1     
Flag Coverage Δ
plugin 78.18% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rch/ad/transport/ForwardADTaskTransportAction.java 94.06% <0.00%> (-3.39%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 76.67% <0.00%> (-0.23%) ⬇️
...opensearch/ad/indices/AnomalyDetectionIndices.java 71.93% <0.00%> (-0.19%) ⬇️
...rch/ad/transport/AnomalyResultTransportAction.java 80.82% <0.00%> (+0.68%) ⬆️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 82.52% <0.00%> (+0.75%) ⬆️
...ansport/handler/AnomalyResultBulkIndexHandler.java 70.96% <0.00%> (+3.22%) ⬆️

@amitgalitz amitgalitz merged commit 52bb9c8 into opensearch-project:main Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra Changes to infrastructure, testing, CI/CD, pipelines, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Plugin contains checked in JARs with unclear provenance
4 participants