[Backport to 1.3] restart bug fix #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix restart HCAD detector bug To prevent repeatedly cold starting a model due to sparse data, HCAD has a cache that remembers we have done cold start for a model. A second attempt to cold start will need to wait for 60 detector intervals. Previously, when stopping a detector, I forgot to clean the cache. So the cache remembers the model and won’t retry cold start after some time. This PR fixes the bug by cleaning the cache when stopping a detector. Testing done: 1. added unit and integration tests. 2. manually reproduced the issue and verified the fix. Signed-off-by: Kaituo Li <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 1.3 #496 +/- ##
============================================
+ Coverage 77.68% 77.75% +0.06%
- Complexity 4111 4116 +5
============================================
Files 296 296
Lines 17669 17673 +4
Branches 1878 1878
============================================
+ Hits 13727 13742 +15
+ Misses 3043 3029 -14
- Partials 899 902 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Seems like test retry isn't helping here as much, is it just a lot more flaky on jdk8? |
amitgalitz
previously approved these changes
Apr 9, 2022
not sure. Will debug after oncall. |
Signed-off-by: Kaituo Li <[email protected]>
ylwu-amzn
approved these changes
Apr 22, 2022
amitgalitz
approved these changes
Apr 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
backport #460 and #456 to 1.3 branch.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.