Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removing job-scheduler zip for 1.3 branch #475

Merged
merged 4 commits into from
Apr 1, 2022

Conversation

amitgalitz
Copy link
Member

Signed-off-by: Amit Galitzky [email protected]

Description

Draft PR to try out removing job-scheduler zip for integ testing and bwc testing for current version.
This is cut against 1.3 branch since 2.0 branch currently is having issue with version bump plus unreleased docker image and etc.

Issues Resolved

#17

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
build.gradle Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Mar 30, 2022

Codecov Report

Merging #475 (200d58b) into 1.3 (bf8f2da) will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.3     #475      +/-   ##
============================================
+ Coverage     77.58%   77.72%   +0.13%     
- Complexity     4105     4113       +8     
============================================
  Files           296      296              
  Lines         17669    17669              
  Branches       1878     1878              
============================================
+ Hits          13709    13733      +24     
+ Misses         3057     3036      -21     
+ Partials        903      900       -3     
Flag Coverage Δ
plugin 77.72% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...port/SearchAnomalyDetectorInfoTransportAction.java 64.44% <0.00%> (-4.45%) ⬇️
.../main/java/org/opensearch/ad/ml/CheckpointDao.java 69.55% <0.00%> (-0.65%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 76.67% <0.00%> (-0.16%) ⬇️
...rch/ad/transport/AnomalyResultTransportAction.java 80.86% <0.00%> (+0.68%) ⬆️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 90.12% <0.00%> (+1.23%) ⬆️
...ansport/handler/AnomalyResultBulkIndexHandler.java 70.96% <0.00%> (+1.61%) ⬆️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 82.06% <0.00%> (+3.79%) ⬆️

@amitgalitz amitgalitz marked this pull request as ready for review April 1, 2022 16:14
@amitgalitz amitgalitz mentioned this pull request Apr 1, 2022
1 task
@amitgalitz amitgalitz requested a review from ylwu-amzn April 1, 2022 16:15
@amitgalitz
Copy link
Member Author

@ohltyler in terms of 1.x, it does seem like infra hasn't ran that build since march 23 for core or anything else so job-scheduler and common utils don't have a 1.4 built yet.

@ohltyler
Copy link
Member

ohltyler commented Apr 1, 2022

@ohltyler in terms of 1.x, it does seem like infra hasn't ran that build since march 23 for core or anything else so job-scheduler and common utils don't have a 1.4 built yet.

Yeah, not sure, was supposed to automatically build after I added them to the manifest but I was told there's some bug causing it to not run - could be because there is no 1.4 test manifest. I've kicked off a 1.4 build manually and we'll see what happens.

@ohltyler ohltyler requested a review from Zhangxunmt April 1, 2022 16:57
@amitgalitz amitgalitz merged commit f51cd4e into opensearch-project:1.3 Apr 1, 2022
@opensearch-trigger-bot
Copy link

The backport to 1.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.x 1.x
# Navigate to the new working tree
cd .worktrees/backport-1.x
# Create a new branch
git switch --create backport/backport-475-to-1.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f51cd4e1dcd776a79c31bc59d7d499f91e75e328
# Push it to GitHub
git push --set-upstream origin backport/backport-475-to-1.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.x

Then, create a pull request where the base branch is 1.x and the compare/head branch is backport/backport-475-to-1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants