-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert alpha1 default version #473
Conversation
Signed-off-by: Yaliang Wu <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #473 +/- ##
============================================
- Coverage 78.19% 78.13% -0.06%
+ Complexity 4162 4157 -5
============================================
Files 296 296
Lines 17659 17659
Branches 1879 1879
============================================
- Hits 13808 13798 -10
- Misses 2957 2964 +7
- Partials 894 897 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we blocking opensearch 2.0 build? I am okay with reverting but also okay with just sending new PR to fix when we figure out how to solve all issues
No, this is to make sure new PRs will be checked by CI. For example, if you publish PR to change RCF jar to rc1 maven, the CI won't work at all. We'd better make sure the CI can pass so other PRs can be verified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed backport label.LGTM
Signed-off-by: Yaliang Wu [email protected]
Description
Revert alpha1 default version as it requires more changes than expected. Refer to
ml-commons
PR opensearch-project/ml-commons#257This PR revert the default version change to make sure CI can work.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.