Gradle 7 and Opensearch 2.0 upgrade #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amit Singh <[email protected]>
opensearch-trigger-bot
bot
added
backport 1.x
infra
ylwu-amzn
reviewed
Mar 23, 2022
| compile ("org.jacoco:org.jacoco.ant:0.8.5") { | ||
| implementation group: 'io.protostuff', name: 'protostuff-core', version: '1.8.0' | ||
| implementation group: 'io.protostuff', name: 'protostuff-runtime', version: '1.8.0' | ||
| implementation group: 'io.protostuff', name: 'protostuff-api', version: '1.8.0' |
There was a problem hiding this comment.
Why add these new dependencies: protostuff-api and protostuff-collectionschema?
There was a problem hiding this comment.
These required to be explicitly added as the compilation errors for Linkedbuffer and Schema were coming from these.
Compile failures : https://paste.amazon.com/show/snghes/1647551203
Codecov Report
@@ Coverage Diff @@
## main #464 +/- ##
============================================
- Coverage 78.33% 78.31% -0.03%
+ Complexity 4172 4169 -3
============================================
Files 296 296
Lines 17657 17655 -2
Branches 1879 1879
============================================
- Hits 13832 13826 -6
+ Misses 2945 2940 -5
- Partials 880 889 +9
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ylwu-amzn
reviewed
Mar 23, 2022
| testCompileOnly 'org.apiguardian:apiguardian-api:1.1.0' | ||
| testImplementation 'org.junit.jupiter:junit-jupiter-api:5.7.2' | ||
| testImplementation 'org.junit.jupiter:junit-jupiter-params:5.7.2' | ||
| testImplementation 'org.junit.jupiter:junit-jupiter-params:5.7.2' |
ylwu-amzn
approved these changes
Mar 24, 2022
amitgalitz
reviewed
Mar 24, 2022
amitgalitz
reviewed
Mar 24, 2022
amitgalitz
reviewed
Mar 24, 2022
| @@ -919,10 +919,7 @@ private void updateMappingIfNecessary(GroupedActionListener<Void> delegateListen | |||
| adminClient | |||
| .indices() | |||
| .putMapping( | |||
| new PutMappingRequest() | |||
| .indices(adIndex.getIndexName()) | |||
| .type(CommonName.MAPPING_TYPE) | |||
There was a problem hiding this comment.
if all uses of CommonName.Mapping_TYPE were removed we can maybe delete that constant and comment referring elastic above it in CommonName class
There was a problem hiding this comment.
Good call out.would do that in separate PR.This is already many files
amitgalitz
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Singh [email protected]
This PR support major campagins for Opensearch 2.0 release :
1.Using OS 2.0 snapshot
2.Remove mapping types ,transport deprecation support
3.Gradle 7 upgrade
Issues Resolved
#326
opensearch-project/opensearch-plugins#130
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.