Changed forbiddenAPIsTest files and made relevant forbidden fixes

[amitgalitz]

Signed-off-by: Amit Galitzky [email protected]

Description

1. Added a new custom signature file for forbiddenAPIsTest
2. Replaced printStackTrace calls with more specific logger.error()
3. Added Locale.ROOT too a lot of string.format() calls.
4. Added Charset.defaultCharset() to calls to read files in testing
5. Removed ignoreFailures = true for forbiddenAPIsTest, this is pretty much the most long lasting change as build will now fail if we add new code that with format not using Locale instead of stacking up a list of hundreds of warning over time (this can be changed back so only warnings are shown and not failures if it proves to be too constrictive.)

Issues Resolved

resolves #422

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ylwu-amzn]

LGTM. Thanks for improving the code style

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.17%. Comparing base (fa00555) to head (dd4c3e9).
Report is 212 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #450      +/-   ##
============================================
- Coverage     78.18%   78.17%   -0.02%     
  Complexity     4162     4162              
============================================
  Files           296      296              
  Lines         17659    17659              
  Branches       1879     1879              
============================================
- Hits          13807    13805       -2     
- Misses         2958     2960       +2     
  Partials        894      894              

Flag	Coverage Δ
plugin	78.17% <ø> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes