Changed default description to empty string instead of null

[amitgalitz]

Signed-off-by: Amit Galitzky [email protected]

Description

Changed the default description field to be set to an empty string instead of a null field. This means that description should also be changed from a required field as listed in documentation to an optional field since if detector description is missing then it will be filled as an empty string.

Currently if there is a missing description field, the backend still creates the detector even though it is listed as required which causes issues on the frontend which tries to parse a null a value unsuccessfully when getting the relevant detector.

Other option is to throw an exception if description is missing and hence enforce the required description which we don't enforce on the backend today and we also let users know it is optional on the frontend, where we just have it as empty if not filled out. For this reason, it makes more sense to just keep it consistent as an 'optional' field from UX point of view.

Reproduced the bug stated in the issue before change was made and tested that bug doesn't occur after this change

Issues Resolved

resolves #437

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #438 (b09bbcf) into main (8550816) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #438      +/-   ##
============================================
- Coverage     77.70%   77.57%   -0.14%     
+ Complexity     4111     4109       -2     
============================================
  Files           296      296              
  Lines         17657    17657              
  Branches       1879     1879              
============================================
- Hits          13720    13697      -23     
- Misses         3032     3058      +26     
+ Partials        905      902       -3     

Flag	Coverage Δ
plugin	77.57% <100.00%> (-0.14%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
.../java/org/opensearch/ad/model/AnomalyDetector.java	91.92% <100.00%> (ø)
...port/SearchAnomalyDetectorInfoTransportAction.java	60.00% <0.00%> (-4.45%)	⬇️
...rch/ad/transport/ForwardADTaskTransportAction.java	94.06% <0.00%> (-3.39%)	⬇️
...va/org/opensearch/ad/feature/SearchFeatureDao.java	84.56% <0.00%> (-2.08%)	⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java	75.69% <0.00%> (-0.99%)	⬇️
...java/org/opensearch/ad/task/ADBatchTaskRunner.java	81.76% <0.00%> (+0.15%)	⬆️
...opensearch/ad/indices/AnomalyDetectionIndices.java	72.28% <0.00%> (+0.18%)	⬆️
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java	90.12% <0.00%> (+1.23%)	⬆️

[ohltyler]

@amitgalitz thanks for the quick work and owning this issue!

[amitgalitz]

rebased with main @ohltyler @ylwu-amzn