Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove jcenter dependency #361

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

amitgalitz
Copy link
Member

@amitgalitz amitgalitz commented Jan 13, 2022

Signed-off-by: Amit Galitzky [email protected]

Description

Removed jcenter dependency as it is no longer operating. We have mavenCentral() as a fallback.

Issues Resolved

resolves #357

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amit Galitzky <[email protected]>
@amitgalitz amitgalitz requested a review from a team January 13, 2022 18:04
@ohltyler
Copy link
Member

fyi: if you add closes or resolves keyword in front of the issue number, it will automatically link it and close it once the PR is merged

@amitgalitz
Copy link
Member Author

fyi: if you add closes or resolves keyword in front of the issue number, it will automatically link it and close it once the PR is merged

thanks for the tip, just added it

@codecov-commenter
Copy link

Codecov Report

Merging #361 (c1a8f80) into main (af2763c) will decrease coverage by 0.36%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #361      +/-   ##
============================================
- Coverage     79.12%   78.75%   -0.37%     
+ Complexity     4090     4063      -27     
============================================
  Files           295      295              
  Lines         17207    17207              
  Branches       1826     1826              
============================================
- Hits          13615    13552      -63     
- Misses         2700     2755      +55     
- Partials        892      900       +8     
Flag Coverage Δ
plugin 78.75% <ø> (-0.37%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...java/org/opensearch/ad/task/ADBatchTaskRunner.java 77.81% <0.00%> (-3.96%) ⬇️
...g/opensearch/ad/model/DetectorValidationIssue.java 64.91% <0.00%> (-3.51%) ⬇️
src/main/java/org/opensearch/ad/model/ADTask.java 94.96% <0.00%> (-2.78%) ⬇️
...c/main/java/org/opensearch/ad/util/ParseUtils.java 70.03% <0.00%> (-1.56%) ⬇️
...ain/java/org/opensearch/ad/task/ADTaskManager.java 74.03% <0.00%> (-1.29%) ⬇️
...ava/org/opensearch/ad/task/ADTaskCacheManager.java 88.36% <0.00%> (-0.96%) ⬇️
...rch/ad/transport/ForwardADTaskTransportAction.java 93.22% <0.00%> (-0.85%) ⬇️
...in/java/org/opensearch/ad/model/AnomalyResult.java 82.27% <0.00%> (-0.67%) ⬇️
...opensearch/ad/indices/AnomalyDetectionIndices.java 72.28% <0.00%> (ø)
...ava/org/opensearch/ad/task/ADHCBatchTaskCache.java 91.35% <0.00%> (+2.46%) ⬆️
... and 1 more

@amitgalitz amitgalitz merged commit 9a74eb9 into opensearch-project:main Jan 13, 2022
amitgalitz added a commit to amitgalitz/anomaly-detection-1 that referenced this pull request Jan 13, 2022
amitgalitz added a commit to amitgalitz/anomaly-detection-1 that referenced this pull request Jan 13, 2022
amitgalitz added a commit that referenced this pull request Jan 13, 2022
amitgalitz added a commit that referenced this pull request Jan 15, 2022
@amitgalitz amitgalitz added the bug Something isn't working label Jan 18, 2022
@amitgalitz amitgalitz deleted the remove-jcenter branch February 9, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove jcenter repository
4 participants