-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not git ignore job scheduler dir, used. #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The CI workflow failure fixed in PR #350
You can rebase your branch on main
to pass CI workflow. But as this PR just change .gitignore
file, I think it's safe to skip the CI workflow. So it's up to you.
Signed-off-by: dblock <[email protected]>
Are there any downsides to having it not be a part of .gitignore and potentially committing it when developing with an older job-scheduler build. I suppose that wont happen often but just wondering if you had any other thoughts on this as it was explicitly added to .gitignore in the past |
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
============================================
+ Coverage 77.57% 77.71% +0.13%
- Complexity 4008 4019 +11
============================================
Files 295 295
Lines 17188 17188
Branches 1816 1816
============================================
+ Hits 13334 13357 +23
+ Misses 3005 2986 -19
+ Partials 849 845 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AFAIK bwc CI won't work without these The fact that any dependency JARs are checked into the project are a problem. I opened #352. |
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock <[email protected]>
Signed-off-by: dblock [email protected]
Description
When updating to 1.2.4 a .zip file was not git add-ed, had to do it manually.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.