Added validation integration tests with security #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylwu-amzn
previously approved these changes
Dec 23, 2021
|
LGTM, make sure CI workflow can pass before merging to main branch. |
ohltyler
reviewed
Jan 3, 2022
| // User Alice has AD full access, should be able to validate a detector | ||
| AnomalyDetector aliceDetector = createRandomAnomalyDetector(false, false, aliceClient); | ||
| Response validateResponse = validateAnomalyDetector(aliceDetector, aliceClient); | ||
| Assert.assertNotNull("User alice validatedDetector", validateResponse); |
There was a problem hiding this comment.
Should the response be more user-friendly, like validated detector instead of validatedDetector?
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
amitgalitz
force-pushed
the
validation_IT_security
branch
from
3c4dd7a to
1430d1a
Compare
ohltyler
approved these changes
Jan 7, 2022
ylwu-amzn
approved these changes
Jan 7, 2022
ylwu-amzn
pushed a commit
to ylwu-amzn/anomaly-detection-2
that referenced
this pull request
Jan 11, 2022
) Signed-off-by: Amit Galitzky <[email protected]>
1 task
ylwu-amzn
pushed a commit
that referenced
this pull request
Jan 12, 2022
Signed-off-by: Amit Galitzky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Amit Galitzky [email protected]
Description
Added new integration for security enabled tests. Checks validation API with different user permissions.
Separate PR since I had issues with CI workflow at first for these tests. Should be solved now.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.