changed condition

Signed-off-by: Amit Galitzky <[email protected]>
opensearch-project · Nov 21, 2024 · 6089c28 · 6089c28
1 parent de8061a
commit 6089c28
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/main/java/org/opensearch/ad/ml/IgnoreSimilarExtractor.java b/src/main/java/org/opensearch/ad/ml/IgnoreSimilarExtractor.java
@@ -54,7 +54,7 @@ public static ThresholdArrays processDetectorRules(AnomalyDetector detector) {
             for (Rule rule : rules) {
                 for (Condition condition : rule.getConditions()) {
                     if (condition.getThresholdType() != ThresholdType.ACTUAL_IS_BELOW_EXPECTED
-                        || condition.getThresholdType() != ThresholdType.ACTUAL_IS_OVER_EXPECTED) {
+                        && condition.getThresholdType() != ThresholdType.ACTUAL_IS_OVER_EXPECTED) {
                         processCondition(
                             condition,
                             featureNames,

diff --git a/src/main/java/org/opensearch/ad/model/Condition.java b/src/main/java/org/opensearch/ad/model/Condition.java
@@ -70,7 +70,7 @@ public static Condition parse(XContentParser parser) throws IOException {
                 case THRESHOLD_TYPE_FIELD:
                     thresholdType = ThresholdType.valueOf(parser.text().toUpperCase(Locale.ROOT));
                     break;
-                case "operator":
+                case OPERATOR_FIELD:
                     if (parser.currentToken() == XContentParser.Token.VALUE_NULL) {
                         operator = null; // Set operator to null if the field is missing
                     } else {
@@ -79,7 +79,7 @@ public static Condition parse(XContentParser parser) throws IOException {
                     break;
                 case VALUE_FIELD:
                     if (parser.currentToken() == XContentParser.Token.VALUE_NULL) {
-                        value = null;
+                        value = null; // Set value to null if the field is missing
                     } else {
                         value = parser.doubleValue();
                     }

diff --git a/src/main/java/org/opensearch/timeseries/transport/ResultResponse.java b/src/main/java/org/opensearch/timeseries/transport/ResultResponse.java
@@ -90,7 +90,7 @@ public boolean shouldSave() {
     }
 
     public abstract List<IndexableResultType> toIndexableResults(
-        Config configId,
+        Config config,
         Instant dataStartInstant,
         Instant dataEndInstant,
         Instant executionStartInstant,