Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version dependency in cypress workflow #554

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Jul 13, 2023

Description

Remove version dependency in cypress workflow by fetching the OpenSearch version value from config file. Now, the auto-created version bump PRs should be sufficient to update all places where versions need bumped.

Moved around steps a bit so the version could be fetched before spinning up OpenSearch cluster

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

ohltyler added 5 commits July 13, 2023 15:26
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
Signed-off-by: Tyler Ohlsen <[email protected]>
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #554 (f64962e) into main (71bf78b) will decrease coverage by 1.73%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #554      +/-   ##
==========================================
- Coverage   51.98%   50.25%   -1.73%     
==========================================
  Files         149      166      +17     
  Lines        5030     5593     +563     
  Branches      983     1055      +72     
==========================================
+ Hits         2615     2811     +196     
- Misses       2156     2511     +355     
- Partials      259      271      +12     

see 22 files with indirect coverage changes

@ohltyler ohltyler merged commit e6d15ec into opensearch-project:main Jul 13, 2023
@ohltyler ohltyler deleted the remove-version-dep branch July 13, 2023 23:40
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-554-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e6d15ecb1a906c0e1c9f2d25286aeca1fcb1f8dc
# Push it to GitHub
git push --set-upstream origin backport/backport-554-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-554-to-2.x.

ohltyler added a commit to ohltyler/anomaly-detection-dashboards-plugin-1 that referenced this pull request Jul 13, 2023
ohltyler added a commit to ohltyler/anomaly-detection-dashboards-plugin-1 that referenced this pull request Jul 14, 2023
ohltyler added a commit that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x github actions Updating or adding GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants