Feature anywhere #530

amitgalitz · 2023-07-10T17:49:35Z

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Tyler Ohlsen <[email protected]>

Signed-off-by: Amit Galitzky <[email protected]>

#384) Signed-off-by: Jackie Han <[email protected]> Signed-off-by: Jackie Han <[email protected]>

Signed-off-by: Tyler Ohlsen <[email protected]>

#388) Signed-off-by: dblock <[email protected]>

Signed-off-by: Tyler Ohlsen <[email protected]>

Signed-off-by: Kaituo Li <[email protected]>

Previously, we didn't actually add filter type when loading old detector. This PR fixed that. Testing done: 1. added a unit tes 2. verified e2et Signed-off-by: Kaituo Li <[email protected]>

Required minimum intervals to finish cold start is related to shingle size. This PR adds the shingle size in the computation and puts the result in the cold start message. Testing done: 1. verified changing shingle size will change the message. Signed-off-by: Kaituo Li <[email protected]>

Signed-off-by: Tyler Ohlsen <[email protected]>

Signed-off-by: dblock <[email protected]>

Signed-off-by: Tyler Ohlsen <[email protected]>

Signed-off-by: Miki <[email protected]>

Signed-off-by: Jackie Han <[email protected]>

* adding an AD expression function Signed-off-by: Amit Galitzky <[email protected]> * making expression fn changes only to plugin.ts Signed-off-by: Amit Galitzky <[email protected]> * addressing comments, changed a few constants Signed-off-by: Amit Galitzky <[email protected]> * moving getDetectorName into try catch Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]>

* Register AD as dashboard context menu option Signed-off-by: Jackie Han <[email protected]> * addressing comments Signed-off-by: Jackie Han <[email protected]> * add getActions props Signed-off-by: Jackie Han <[email protected]> * add EmbeddableStart Signed-off-by: Jackie Han <[email protected]> * remove spread operator Signed-off-by: Jackie Han <[email protected]> * clenaup Signed-off-by: Jackie Han <[email protected]> * add overlay getter and setter Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]>

* working js manage detectors Signed-off-by: Amit Galitzky <[email protected]> * adding associated detectors page Signed-off-by: Amit Galitzky <[email protected]> * adding unlink modal confirmation Signed-off-by: Amit Galitzky <[email protected]> * prettier formating and merge conflicts Signed-off-by: Amit Galitzky <[email protected]> * add unlinking capability Signed-off-by: Amit Galitzky <[email protected]> * adding message for no search results Signed-off-by: Amit Galitzky <[email protected]> * clean up files Signed-off-by: Amit Galitzky <[email protected]> * more cleanup Signed-off-by: Amit Galitzky <[email protected]> * making changes based on new upper container Signed-off-by: Amit Galitzky <[email protected]> * ran prettier Signed-off-by: Amit Galitzky <[email protected]> * fix notification and clean up associated detectors Signed-off-by: Amit Galitzky <[email protected]> * addressing comments Signed-off-by: Amit Galitzky <[email protected]> * renaming some files and adding index.ts Signed-off-by: Amit Galitzky <[email protected]> * Added license to new files Signed-off-by: Amit Galitzky <[email protected]> * clean up after rebase Signed-off-by: Amit Galitzky <[email protected]> * addressed more comments Signed-off-by: Amit Galitzky <[email protected]> * added notifications service as a getter-setter Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]>

* Add create detector flyout page Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * run prettier Signed-off-by: Jackie Han <[email protected]> * remove enzyme usage Signed-off-by: Jackie Han <[email protected]> * reuse existing helper function when creating detector Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * rebase with associated detector change Signed-off-by: Jackie Han <[email protected]> * move helper functions to helper file Signed-off-by: Jackie Han <[email protected]> * use VisLayerTypes for VisLayerExpressionFn Signed-off-by: Jackie Han <[email protected]> * address comments Signed-off-by: Jackie Han <[email protected]> * use OVERLAY_ANOMALIES constant Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> Signed-off-by: Jackie Han <[email protected]>

…ion (#484) * Adding associate existing Signed-off-by: Amit Galitzky <[email protected]> * removed usememo, addressed other comments Signed-off-by: Amit Galitzky <[email protected]> * merge cleanup Signed-off-by: Amit Galitzky <[email protected]> * added integration to call on alerting Signed-off-by: Amit Galitzky <[email protected]> * cleaned up files and added changes to check if detector is deleted in expr fn Signed-off-by: Amit Galitzky <[email protected]> * fixing dependency and notifcations issues Signed-off-by: Amit Galitzky <[email protected]> * removed long toast life time Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]>

Signed-off-by: Amit Galitzky <[email protected]>

* add jest transform config Signed-off-by: Jackie Han <[email protected]> * add license header Signed-off-by: Jackie Han <[email protected]> * update file as .ts file Signed-off-by: Jackie Han <[email protected]> * add comment on jest config file Signed-off-by: Jackie Han <[email protected]> * add more comments Signed-off-by: Jackie Han <[email protected]> * cleanup Signed-off-by: Jackie Han <[email protected]> * update file export Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]>

* Add branch constants in CI workflow (#345) Signed-off-by: Tyler Ohlsen <[email protected]> * Bump decode-uri-component (#359) Signed-off-by: Tyler Ohlsen <[email protected]> * removed duplicate popout icon and ran prettier (#382) Signed-off-by: Amit Galitzky <[email protected]> * Change detector out of time range modal warning into a callout warning (#384) Signed-off-by: Jackie Han <[email protected]> Signed-off-by: Jackie Han <[email protected]> * Fix undefined entity list when heatmap is empty (#383) Signed-off-by: Tyler Ohlsen <[email protected]> * Updated MAINTAINERS.md to match recommended opensearch-project format. (#388) Signed-off-by: dblock <[email protected]> * Add windows env to integration test workflow (#390) Signed-off-by: Tyler Ohlsen <[email protected]> * Bump json5 to 2.2.3 (#393) Signed-off-by: Tyler Ohlsen <[email protected]> * Add 2.5 release notes (#395) Signed-off-by: Tyler Ohlsen <[email protected]> * Update cold start message (#398) Signed-off-by: Kaituo Li <[email protected]> * upgrade filter bug (#402) Previously, we didn't actually add filter type when loading old detector. This PR fixed that. Testing done: 1. added a unit tes 2. verified e2et Signed-off-by: Kaituo Li <[email protected]> * Changed required minimum intervals in cold start message (#411) Required minimum intervals to finish cold start is related to shingle size. This PR adds the shingle size in the computation and puts the result in the cold start message. Testing done: 1. verified changing shingle size will change the message. Signed-off-by: Kaituo Li <[email protected]> * Bump @sideway/formula to 3.0.1 (#418) Signed-off-by: Tyler Ohlsen <[email protected]> * Remove auto_expand_replicas override in sample data indices (#423) Signed-off-by: Tyler Ohlsen <[email protected]> * Created untriaged issue workflow. (#422) Signed-off-by: dblock <[email protected]> * Add 2.6 release notes (#429) Signed-off-by: Tyler Ohlsen <[email protected]> * Fix Node.js and Yarn installation in CI (#433) Signed-off-by: Miki <[email protected]> * run prettier command against all files (#444) Signed-off-by: Jackie Han <[email protected]> * Add 2.7 release notes (#456) Signed-off-by: Jackie Han <[email protected]> * updating maintainers and code owners (#476) Signed-off-by: Amit Galitzky <[email protected]> * fixing test to pass with node 18 (#491) Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: Amit Galitzky <[email protected]> Signed-off-by: Jackie Han <[email protected]> Signed-off-by: dblock <[email protected]> Signed-off-by: Kaituo Li <[email protected]> Signed-off-by: Miki <[email protected]> Co-authored-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jackie Han <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Kaituo Li <[email protected]> Co-authored-by: Miki <[email protected]>

* adding UT for expression function and some components Signed-off-by: Amit Galitzky <[email protected]> * moved helper functions to separate files, cleaned up other tests Signed-off-by: Amit Galitzky <[email protected]> * custom result bug fix along with a few others Signed-off-by: Amit Galitzky <[email protected]> * revert historical boolean Signed-off-by: Amit Galitzky <[email protected]> * add pluginEventType when no error Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]>

* fix bug bash bugs Signed-off-by: Jackie Han <[email protected]> * bug fix Signed-off-by: Jackie Han <[email protected]> * yarn prettier Signed-off-by: Jackie Han <[email protected]> * bug fix Signed-off-by: Jackie Han <[email protected]> * bug fixes Signed-off-by: Jackie Han <[email protected]> * clean up code Signed-off-by: Jackie Han <[email protected]> * removed unused snapshot Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]> Signed-off-by: Jackie Han <[email protected]>

* associated detectors unit tests Signed-off-by: Amit Galitzky <[email protected]> * fixed some bugs and added unit tests for associated detectors Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]>

* make feature anywhere formatted detector name an assgiend value to return Signed-off-by: Jackie Han <[email protected]> * update feature anywhere documentation link Signed-off-by: Jackie Han <[email protected]> * correct type Signed-off-by: Jackie Han <[email protected]> * correct typo Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]>

Signed-off-by: Amit Galitzky <[email protected]>

Signed-off-by: David Sinclair <[email protected]>

Signed-off-by: Jackie Han <[email protected]>

* update categorical field text on Feature Anywhere flyout Signed-off-by: Jackie Han <[email protected]> * Use non-breaking space character to prevent removing needed empty space by yarn prettier Signed-off-by: Jackie Han <[email protected]> * Fix the max width of associate detector flyout to 740px Signed-off-by: Jackie Han <[email protected]> --------- Signed-off-by: Jackie Han <[email protected]>

Signed-off-by: Amit Galitzky <[email protected]>

Signed-off-by: Jackie Han <[email protected]>

Signed-off-by: Tyler Ohlsen <[email protected]>

) * adding a callout when association limit has been reached Signed-off-by: Amit Galitzky <[email protected]> * fixed limit check and ran prettier Signed-off-by: Amit Galitzky <[email protected]> --------- Signed-off-by: Amit Galitzky <[email protected]>

* Add branch constants in CI workflow (#345) Signed-off-by: Tyler Ohlsen <[email protected]> * Bump decode-uri-component (#359) Signed-off-by: Tyler Ohlsen <[email protected]> * removed duplicate popout icon and ran prettier (#382) Signed-off-by: Amit Galitzky <[email protected]> * Change detector out of time range modal warning into a callout warning (#384) Signed-off-by: Jackie Han <[email protected]> Signed-off-by: Jackie Han <[email protected]> * Fix undefined entity list when heatmap is empty (#383) Signed-off-by: Tyler Ohlsen <[email protected]> * Updated MAINTAINERS.md to match recommended opensearch-project format. (#388) Signed-off-by: dblock <[email protected]> * Add windows env to integration test workflow (#390) Signed-off-by: Tyler Ohlsen <[email protected]> * Bump json5 to 2.2.3 (#393) Signed-off-by: Tyler Ohlsen <[email protected]> * Add 2.5 release notes (#395) Signed-off-by: Tyler Ohlsen <[email protected]> * Update cold start message (#398) Signed-off-by: Kaituo Li <[email protected]> * upgrade filter bug (#402) Previously, we didn't actually add filter type when loading old detector. This PR fixed that. Testing done: 1. added a unit tes 2. verified e2et Signed-off-by: Kaituo Li <[email protected]> * Changed required minimum intervals in cold start message (#411) Required minimum intervals to finish cold start is related to shingle size. This PR adds the shingle size in the computation and puts the result in the cold start message. Testing done: 1. verified changing shingle size will change the message. Signed-off-by: Kaituo Li <[email protected]> * Bump @sideway/formula to 3.0.1 (#418) Signed-off-by: Tyler Ohlsen <[email protected]> * Remove auto_expand_replicas override in sample data indices (#423) Signed-off-by: Tyler Ohlsen <[email protected]> * Created untriaged issue workflow. (#422) Signed-off-by: dblock <[email protected]> * Add 2.6 release notes (#429) Signed-off-by: Tyler Ohlsen <[email protected]> * Fix Node.js and Yarn installation in CI (#433) Signed-off-by: Miki <[email protected]> * run prettier command against all files (#444) Signed-off-by: Jackie Han <[email protected]> * Add 2.7 release notes (#456) Signed-off-by: Jackie Han <[email protected]> * updating maintainers and code owners (#476) Signed-off-by: Amit Galitzky <[email protected]> * fixing test to pass with node 18 (#491) Signed-off-by: Amit Galitzky <[email protected]> * add 2.8.0 release notes (#500) Signed-off-by: Kaituo Li <[email protected]> * Remove invalid link (#470) Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> * Remove global OUI style override (#511) Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: Amit Galitzky <[email protected]> Signed-off-by: Jackie Han <[email protected]> Signed-off-by: dblock <[email protected]> Signed-off-by: Kaituo Li <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Peter Nied <[email protected]> Signed-off-by: Matt Provost <[email protected]> Co-authored-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jackie Han <[email protected]> Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]> Co-authored-by: Kaituo Li <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Peter Nied <[email protected]> Co-authored-by: Matt Provost <[email protected]>

Signed-off-by: Jackie Han <[email protected]>

ohltyler and others added 30 commits March 22, 2023 12:54

Add branch constants in CI workflow (#345)

4c56d6d

Signed-off-by: Tyler Ohlsen <[email protected]>

Bump decode-uri-component (#359)

4928c50

Signed-off-by: Tyler Ohlsen <[email protected]>

removed duplicate popout icon and ran prettier (#382)

45b7e6f

Signed-off-by: Amit Galitzky <[email protected]>

Change detector out of time range modal warning into a callout warning (

d57e09e

#384) Signed-off-by: Jackie Han <[email protected]> Signed-off-by: Jackie Han <[email protected]>

Fix undefined entity list when heatmap is empty (#383)

5487605

Signed-off-by: Tyler Ohlsen <[email protected]>

Updated MAINTAINERS.md to match recommended opensearch-project format. (

00aaaba

#388) Signed-off-by: dblock <[email protected]>

Add windows env to integration test workflow (#390)

6de242a

Signed-off-by: Tyler Ohlsen <[email protected]>

Bump json5 to 2.2.3 (#393)

104ae4d

Signed-off-by: Tyler Ohlsen <[email protected]>

Add 2.5 release notes (#395)

9e253ed

Signed-off-by: Tyler Ohlsen <[email protected]>

Update cold start message (#398)

e797f2b

Signed-off-by: Kaituo Li <[email protected]>

upgrade filter bug (#402)

aec5339

Previously, we didn't actually add filter type when loading old detector. This PR fixed that. Testing done: 1. added a unit tes 2. verified e2et Signed-off-by: Kaituo Li <[email protected]>

Bump @sideway/formula to 3.0.1 (#418)

ed47e94

Signed-off-by: Tyler Ohlsen <[email protected]>

Remove auto_expand_replicas override in sample data indices (#423)

ec57b1d

Signed-off-by: Tyler Ohlsen <[email protected]>

Created untriaged issue workflow. (#422)

071f836

Signed-off-by: dblock <[email protected]>

Add 2.6 release notes (#429)

e2f1238

Signed-off-by: Tyler Ohlsen <[email protected]>

Fix Node.js and Yarn installation in CI (#433)

553cbdd

Signed-off-by: Miki <[email protected]>

run prettier command against all files

e9f8eac

Signed-off-by: Jackie Han <[email protected]>

switched argument order (#494)

5e76e44

Signed-off-by: Amit Galitzky <[email protected]>

amitgalitz and others added 10 commits June 12, 2023 14:02

various bug fixes for anywhere features (#507)

261df11

Signed-off-by: Amit Galitzky <[email protected]>

add group category and order for context menu (#495)

c286b8c

Signed-off-by: David Sinclair <[email protected]>

Update Advanced configuration accordion title (#513)

c1a4846

Signed-off-by: Jackie Han <[email protected]>

fixing vis eligibility (#519)

bb80536

Signed-off-by: Amit Galitzky <[email protected]>

render embeddable by using vis embeddable (#521)

8e905d1

Signed-off-by: Jackie Han <[email protected]>

Change to anomaly start time; add test ids (#522)

39894dd

Signed-off-by: Tyler Ohlsen <[email protected]>

amitgalitz requested review from ohltyler, kaituo, jackiehanyang and sean-zheng-amazon as code owners July 10, 2023 17:49

opensearch-trigger-bot bot added documentation Improvements or additions to documentation github actions Updating or adding GitHub actions dependencies Pull requests that update a dependency file backport 2.x labels Jul 10, 2023

jackiehanyang mentioned this pull request Jul 10, 2023

copy files from main to resolve conflicts #533

Merged

4 tasks

copy files from main to resolve conflicts (#533)

9d20563

Signed-off-by: Jackie Han <[email protected]>

jackiehanyang closed this Jul 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature anywhere #530

Feature anywhere #530

amitgalitz commented Jul 10, 2023

Feature anywhere #530

Feature anywhere #530

Conversation

amitgalitz commented Jul 10, 2023

Description

Issues Resolved

Check List