-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependency Updates #463
Dependency Updates #463
Conversation
This PR includes updates to several dependencies in order to address known Common Vulnerabilities and Exposures (CVEs). The following dependencies have been updated: * axios * minimist * moment * minimatch It's worth noting that the updated versions were determined based on the analysis of CVE scopes (the range of affected versions) and by referring to working versions used in other repositories or branches. The following sources were consulted: alerting-dashboards-plugin opensearch-js anomaly-detection-dashboards-plugin OpenSearch-Dashboards Signed-off-by: Kaituo Li <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## 1.3 #463 +/- ##
=======================================
Coverage 45.91% 45.91%
=======================================
Files 150 150
Lines 4957 4957
Branches 956 956
=======================================
Hits 2276 2276
Misses 2463 2463
Partials 218 218 |
Cypress tests failed:
Note: Overriding Cypress cache directory to: /home/runner/.cache/Cypress
Cypress 5.6.0 is installed in /home/runner/.cache/Cypress/5.6.0 added 224 packages in 396.097s We are verifying this server because it has been configured as your Cypress automatically waits until your server is accessible before running tests. We will try connecting to it 3 more times... Cypress failed to verify that your server is running. Please start this server and then run Cypress again. This starts failing since last December: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/commits/1.3 Will not fix and use manual test to cover instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I see the integ test failures are the same as when I made the updates here: #452. Are you suggesting pushing anyway as you think its unreleated? |
found the error: let me increment ad dashboard version to 1.3.10 |
The version of OpenSearch Dashboards on branch 1.3 is currently 1.3.10. We need to increment AD dashboard version to 1.3.10 to reflect the latest changes. Signed-off-by: Kaituo Li <[email protected]>
Remote integ tests still failed when running OpenSearch with plugin:
|
@amitgalitz Won't be able to fix now as job scheduler 1.3.10 zip is not available. Please see above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for also updating to 1.3.10
Description
This PR includes updates to several dependencies in order to address known Common Vulnerabilities and Exposures (CVEs). The following dependencies have been updated:
It's worth noting that the updated versions were determined based on the analysis of CVE scopes (the range of affected versions) and by referring to working versions used in other repositories or branches. The following sources were consulted:
alerting-dashboards-plugin
opensearch-js
anomaly-detection-dashboards-plugin
OpenSearch-Dashboards
Testing:
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.