Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency Updates #463

Merged
merged 2 commits into from
May 2, 2023
Merged

Dependency Updates #463

merged 2 commits into from
May 2, 2023

Conversation

kaituo
Copy link
Collaborator

@kaituo kaituo commented May 2, 2023

Description

This PR includes updates to several dependencies in order to address known Common Vulnerabilities and Exposures (CVEs). The following dependencies have been updated:

  • axios
  • minimist
  • moment
  • minimatch

It's worth noting that the updated versions were determined based on the analysis of CVE scopes (the range of affected versions) and by referring to working versions used in other repositories or branches. The following sources were consulted:

alerting-dashboards-plugin
opensearch-js
anomaly-detection-dashboards-plugin
OpenSearch-Dashboards

Testing:

  • did basic e2e smoke testing.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

This PR includes updates to several dependencies in order to address known Common Vulnerabilities and Exposures (CVEs). The following dependencies have been updated:

* axios
* minimist
* moment
* minimatch

It's worth noting that the updated versions were determined based on the analysis of CVE scopes (the range of affected versions) and by referring to working versions used in other repositories or branches. The following sources were consulted:

alerting-dashboards-plugin
opensearch-js
anomaly-detection-dashboards-plugin
OpenSearch-Dashboards

Signed-off-by: Kaituo Li <[email protected]>
@kaituo kaituo requested review from a team, ohltyler and amitgalitz May 2, 2023 00:19
@codecov-commenter
Copy link

Codecov Report

Merging #463 (54dd6c1) into 1.3 (0113155) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##              1.3     #463   +/-   ##
=======================================
  Coverage   45.91%   45.91%           
=======================================
  Files         150      150           
  Lines        4957     4957           
  Branches      956      956           
=======================================
  Hits         2276     2276           
  Misses       2463     2463           
  Partials      218      218           

@kaituo
Copy link
Collaborator Author

kaituo commented May 2, 2023

Cypress tests failed:

[email protected] postinstall /home/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/opensearch-dashboards-functional-test/node_modules/cypress
node index.js --exec install

Note: Overriding Cypress cache directory to: /home/runner/.cache/Cypress

  Previous installs of Cypress may not be found.

Cypress 5.6.0 is installed in /home/runner/.cache/Cypress/5.6.0

added 224 packages in 396.097s
/opt/hostedtoolcache/node/10.24.1/x64/bin/npx cypress cache list
┌─────────┬───────────────┐
│ version │ last used │
├─────────┼───────────────┤
│ 12.11.0 │ 7 minutes ago │
├─────────┼───────────────┤
│ 5.6.0 │ 7 minutes ago │
└─────────┴───────────────┘
Using custom test command: yarn run cypress run --env SECURITY_ENABLED=false --spec cypress/integration/plugins/anomaly-detection-dashboards-plugin/.js
run tests command "yarn run cypress run --env SECURITY_ENABLED=false --spec cypress/integration/plugins/anomaly-detection-dashboards-plugin/
.js"
current working directory "/home/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/opensearch-dashboards-functional-test"
/opt/hostedtoolcache/node/10.24.1/x64/bin/yarn run cypress run --env SECURITY_ENABLED=false --spec cypress/integration/plugins/anomaly-detection-dashboards-plugin/.js
yarn run v1.21.1
$ /home/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/opensearch-dashboards-functional-test/node_modules/.bin/cypress run --env SECURITY_ENABLED=false --spec 'cypress/integration/plugins/anomaly-detection-dashboards-plugin/
.js'
Cypress could not verify that this server is running:

http://localhost:5601

We are verifying this server because it has been configured as your baseUrl.

Cypress automatically waits until your server is accessible before running tests.

We will try connecting to it 3 more times...
We will try connecting to it 2 more times...
We will try connecting to it 1 more time...

Cypress failed to verify that your server is running.

Please start this server and then run Cypress again.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: The process '/opt/hostedtoolcache/node/10.24.1/x64/bin/yarn' failed with exit code 1

This starts failing since last December: https://github.com/opensearch-project/anomaly-detection-dashboards-plugin/commits/1.3

Will not fix and use manual test to cover instead.

ohltyler
ohltyler previously approved these changes May 2, 2023
Copy link
Member

@ohltyler ohltyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amitgalitz
Copy link
Member

I see the integ test failures are the same as when I made the updates here: #452. Are you suggesting pushing anyway as you think its unreleated?

@kaituo
Copy link
Collaborator Author

kaituo commented May 2, 2023

I see the integ test failures are the same as when I made the updates here: #452. Are you suggesting pushing anyway as you think its unreleated?

found the error:
FATAL Error: Failed to initialize plugins:
Plugin “anomalyDetectionDashboards” is only compatible with OpenSearch Dashboards version “1.3.9", but used OpenSearch Dashboards version is “1.3.10”. (incompatible-version, /home/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/OpenSearch-Dashboards/plugins/anomaly-detection-dashboards-plugin/opensearch_dashboards.json)

let me increment ad dashboard version to 1.3.10

The version of OpenSearch Dashboards on branch 1.3 is currently 1.3.10. We need to increment AD dashboard version to 1.3.10 to reflect the latest changes.

Signed-off-by: Kaituo Li <[email protected]>
@kaituo
Copy link
Collaborator Author

kaituo commented May 2, 2023

Remote integ tests still failed when running OpenSearch with plugin:

  • What went wrong:
    Could not determine the dependencies of task ':run'.

Can't get https://ci.opensearch.org/ci/dbc/distribution-build-opensearch/1.3.10/latest/linux/x64/tar/builds/opensearch/plugins/opensearch-job-scheduler-1.3.10.0.zip to /home/runner/work/anomaly-detection-dashboards-plugin/anomaly-detection-dashboards-plugin/anomaly-detection/src/test/resources/job-scheduler/opensearch-job-scheduler-1.3.10.0.zip

@kaituo
Copy link
Collaborator Author

kaituo commented May 2, 2023

@amitgalitz Won't be able to fix now as job scheduler 1.3.10 zip is not available. Please see above.

Copy link
Member

@amitgalitz amitgalitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for also updating to 1.3.10

@kaituo kaituo merged commit 3e6425c into opensearch-project:1.3 May 2, 2023
@ohltyler ohltyler mentioned this pull request May 2, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants