Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 2.5.0; add constants in CI workflow #346

Merged
merged 2 commits into from
Nov 30, 2022

Conversation

ohltyler
Copy link
Member

@ohltyler ohltyler commented Nov 29, 2022

Signed-off-by: Tyler Ohlsen [email protected]

Description

Same as #345 but for 2.x branch.

Also bumps version to 2.5 to be on version parity to run CI successfully.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ohltyler ohltyler added the github actions Updating or adding GitHub actions label Nov 29, 2022
@ohltyler ohltyler requested review from a team, amitgalitz and jackiehanyang November 29, 2022 22:24
@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2022

Codecov Report

Merging #346 (b3c9d85) into 2.x (989bc33) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x     #346   +/-   ##
=======================================
  Coverage   52.04%   52.04%           
=======================================
  Files         147      147           
  Lines        5015     5015           
  Branches      965      965           
=======================================
  Hits         2610     2610           
  Misses       2148     2148           
  Partials      257      257           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ohltyler
Copy link
Member Author

ohltyler commented Nov 30, 2022

Failing because Dashboards 2.x is on 2.5 AD Dashboards and functional-test repo are all on 2.4...

https://github.com/opensearch-project/OpenSearch-Dashboards/blob/2.x/package.json#L14

Signed-off-by: Tyler Ohlsen <[email protected]>
@ohltyler ohltyler changed the title Add branch constants in CI workflow for 2.x Bump to 2.5.0; add constants in CI workflow Nov 30, 2022
@ohltyler
Copy link
Member Author

Re-triggering after opensearch-project/opensearch-dashboards-functional-test#404 is merged

@ohltyler
Copy link
Member Author

JS missing in 2.5 build. Will re-trigger once opensearch-project/opensearch-build#2947 is merged, and once there is a successful 2.5.0 build in jenkins

@ohltyler ohltyler merged commit 1a19567 into opensearch-project:2.x Nov 30, 2022
@amitgalitz amitgalitz mentioned this pull request Jan 10, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github actions Updating or adding GitHub actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants