-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0 version bump #230
2.0 version bump #230
Conversation
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Signed-off-by: Amit Galitzky <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #230 +/- ##
==========================================
+ Coverage 45.90% 45.92% +0.02%
==========================================
Files 150 150
Lines 4956 4956
Branches 955 968 +13
==========================================
+ Hits 2275 2276 +1
Misses 2463 2463
+ Partials 218 217 -1
Continue to review full report at Codecov.
|
</div> | ||
</div> | ||
<div | ||
aria-hidden="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems we changed a lot for alerts flyout. Looks quite simple now. Can you confirm if the AlertsFlyout
snap is correct or not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Investigating this now, ConfirmModal snap also had a lot removed. Need to see why testing isn't opening flyout/modal.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still no clear answer on this. I opened an issue: #231 and will continue investigating with the help on others on dashboard team. For the failing integ-test, the correct UI is still there but for some reason the aria-label for "Daily max" isn't present in the element. I will make a change to fix it on functional-test-repo after this is merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similar thing happened in ISM 2.0 update with their CreateState
snap opensearch-project/index-management-dashboards-plugin@7352cdb#diff-7fde899dd6c89f4ee9fda19ed4cd3eff64cb1e0ba4e6e915d1e6631b42201351R4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved this PR to unblock 2.0 development. You can fix failed IT in separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice. thx Amit
Description
AnnotationDomainTypes
changed toAnnotationDomainType
undefined
rather thannull
SampleDataBox
component to useEuiCard
instead ofContentPanel
. This is becausebetaBadgeLabel
was removed fromEuiPanel
which is used inContentPanel
component. This required a few changes in padding and adding a horizontal line below title manually.SampleDataBox
to display in a grid so cards don't come off screen when minimizing it.Issues Resolved
resolves #221
resolves #222
resolves #164
Check List
--signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.