bump version to 2.8.0 #930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
|
Please update PR description. |
lezzago
reviewed
May 24, 2023
alerting/build.gradle
Outdated
Comment on lines
76
to
77
| // force "com.fasterxml.jackson.core:jackson-core:${versions.jackson}" | ||
| // force "com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:${versions.jackson}" |
There was a problem hiding this comment.
why are we commenting them out?
lezzago
reviewed
May 24, 2023
alerting/src/test/kotlin/org/opensearch/alerting/resthandler/SecureMonitorRestApiIT.kt
Show resolved
Hide resolved
lezzago
requested changes
May 24, 2023
| @@ -1,5 +1,5 @@ | |||
| distributionBase=GRADLE_USER_HOME | |||
| distributionPath=wrapper/dists | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-bin.zip | |||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip | |||
There was a problem hiding this comment.
We need to update the gradle wrapper
Signed-off-by: Surya Sashank Nistala <[email protected]>
…to fix regression Signed-off-by: Surya Sashank Nistala <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #930 +/- ##
============================================
+ Coverage 76.73% 76.80% +0.07%
Complexity 116 116
============================================
Files 125 125
Lines 7221 7253 +32
Branches 1049 1049
============================================
+ Hits 5541 5571 +30
+ Misses 1149 1147 -2
- Partials 531 535 +4
|
Signed-off-by: Surya Sashank Nistala <[email protected]>
lezzago
reviewed
May 24, 2023
| deleteDocLevelMonitorQueriesAndIndices(client, monitor, monitorId) | ||
| deleteMetadata(client, monitor) |
Signed-off-by: Surya Sashank Nistala <[email protected]>
lezzago
approved these changes
May 24, 2023
sbcd90
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades plugin version to 2.8.0
Fixes string entity import in test
Use gradle 7.6.1 distribution to match Opensearch core