Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrate security-analytics & alerting for correlation engine #878

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

sbcd90
Copy link
Collaborator

@sbcd90 sbcd90 commented Apr 18, 2023

Issue #, if available:

Description of changes:
integrate security-analytics & alerting for correlation engine

CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sbcd90 sbcd90 requested a review from a team April 18, 2023 21:50
try {
publishFinding(monitor, monitorCtx, finding)
} catch (e: Exception) {
// suppress exception
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add some logging here

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added logs

@@ -51,6 +51,15 @@
},
"timestamp": {
"type": "long"
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update the schema version when the schema is updated

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated schema version

@AWSHurneyt AWSHurneyt merged commit 37b81fa into opensearch-project:main Apr 19, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2023
* integrate security-analytics & alerting for correlation engine

Signed-off-by: Subhobrata Dey <[email protected]>

* integrate security-analytics & alerting for correlation engine

Signed-off-by: Subhobrata Dey <[email protected]>

* integrate security-analytics & alerting for correlation engine

Signed-off-by: Subhobrata Dey <[email protected]>

---------

Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 37b81fa)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 19, 2023
* integrate security-analytics & alerting for correlation engine

Signed-off-by: Subhobrata Dey <[email protected]>

* integrate security-analytics & alerting for correlation engine

Signed-off-by: Subhobrata Dey <[email protected]>

* integrate security-analytics & alerting for correlation engine

Signed-off-by: Subhobrata Dey <[email protected]>

---------

Signed-off-by: Subhobrata Dey <[email protected]>
(cherry picked from commit 37b81fa)
sbcd90 pushed a commit that referenced this pull request Apr 19, 2023
sbcd90 pushed a commit that referenced this pull request Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants