Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix getAlerts API for standard Alerting monitors (#870) #875

Merged
merged 1 commit into from
Apr 18, 2023

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Apr 18, 2023

Issue #, if available:
#842
Description of changes:
Backport #870
CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

)

* Fix getAlerts API for standard Alerting monitors

Signed-off-by: Ashish Agrawal <[email protected]>
@lezzago lezzago requested a review from a team April 18, 2023 01:42
@lezzago lezzago changed the title Fix getAlerts API for standard Alerting monitors (#870) [Backport 2.x] Fix getAlerts API for standard Alerting monitors (#870) Apr 18, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #875 (000e243) into 2.x (2ac70d2) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #875      +/-   ##
============================================
- Coverage     76.48%   76.46%   -0.03%     
  Complexity      116      116              
============================================
  Files           125      125              
  Lines          7059     7061       +2     
  Branches       1033     1034       +1     
============================================
  Hits           5399     5399              
- Misses         1134     1140       +6     
+ Partials        526      522       -4     
Impacted Files Coverage Δ
...rch/alerting/transport/TransportGetAlertsAction.kt 76.92% <100.00%> (+0.45%) ⬆️

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lezzago lezzago merged commit 493139e into opensearch-project:2.x Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants