Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish snapshots to maven via GHA #805

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Feb 21, 2023

Issue #, if available:
#802

Description of changes:
Publish snapshots to maven via GHA

Testing:

find alerting/snapshots | sort
alerting/snapshots
alerting/snapshots/org
alerting/snapshots/org/opensearch
alerting/snapshots/org/opensearch/plugin
alerting/snapshots/org/opensearch/plugin/alerting
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.pom
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.pom.md5
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.pom.sha1
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.pom.sha256
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.pom.sha512
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.zip
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.zip.md5
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.zip.sha1
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.zip.sha256
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/alerting-3.0.0.0-20230221.175611-1.zip.sha512
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/maven-metadata.xml
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/maven-metadata.xml.md5
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha1
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha256
alerting/snapshots/org/opensearch/plugin/alerting/3.0.0.0-SNAPSHOT/maven-metadata.xml.sha512
alerting/snapshots/org/opensearch/plugin/alerting/maven-metadata.xml
alerting/snapshots/org/opensearch/plugin/alerting/maven-metadata.xml.md5
alerting/snapshots/org/opensearch/plugin/alerting/maven-metadata.xml.sha1
alerting/snapshots/org/opensearch/plugin/alerting/maven-metadata.xml.sha256
alerting/snapshots/org/opensearch/plugin/alerting/maven-metadata.xml.sha512

CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Ashish Agrawal <[email protected]>
@lezzago lezzago requested review from a team and gaiksaya February 21, 2023 15:02
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you post the output of all the publications in the comment just to confirm? Testing information is provided in the issue
Thanks!

.github/workflows/maven-publish.yml Outdated Show resolved Hide resolved
Signed-off-by: Ashish Agrawal <[email protected]>
Copy link
Member

@gaiksaya gaiksaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Added the secret role.

@lezzago lezzago merged commit 06c58b0 into opensearch-project:main Feb 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 21, 2023
Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit 06c58b0)
sbcd90 pushed a commit that referenced this pull request Feb 21, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2023
Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit 06c58b0)
Angie-Zhang pushed a commit that referenced this pull request Mar 2, 2023
Signed-off-by: Ashish Agrawal <[email protected]>
(cherry picked from commit 06c58b0)

Co-authored-by: Ashish Agrawal <[email protected]>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-1.3
# Create a new branch
git switch --create backport-805-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 06c58b0579bc4ec0e71dd4180e4e565f95ec3aa0
# Push it to GitHub
git push --set-upstream origin backport-805-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport-805-to-1.3.

bowenlan-amzn pushed a commit that referenced this pull request Aug 22, 2023
* Publish snapshots to maven via GHA

Signed-off-by: Ashish Agrawal <[email protected]>

* auto publish setup

Signed-off-by: Ashish Agrawal <[email protected]>

---------

Signed-off-by: Ashish Agrawal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants