-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added document _id as param for terms query when searching alerts by … #753
Merged
eirsep
merged 2 commits into
opensearch-project:main
from
stevanbz:748/getting-alerts-by-id-issue
Jan 13, 2023
Merged
Added document _id as param for terms query when searching alerts by … #753
eirsep
merged 2 commits into
opensearch-project:main
from
stevanbz:748/getting-alerts-by-id-issue
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…their ids Signed-off-by: Stevan Buzejic <[email protected]>
5 tasks
Signed-off-by: Stevan Buzejic <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #753 +/- ##
============================================
- Coverage 75.43% 75.29% -0.15%
Complexity 116 116
============================================
Files 125 125
Lines 6828 6828
Branches 1024 1024
============================================
- Hits 5151 5141 -10
- Misses 1143 1155 +12
+ Partials 534 532 -2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
eirsep
approved these changes
Jan 13, 2023
sbcd90
approved these changes
Jan 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
#753) * Added document _id as param for terms query when searching alerts by their ids Signed-off-by: Stevan Buzejic <[email protected]> * Empty-Commit Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> (cherry picked from commit 8084943)
This was referenced Jan 13, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jan 13, 2023
#753) * Added document _id as param for terms query when searching alerts by their ids Signed-off-by: Stevan Buzejic <[email protected]> * Empty-Commit Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> (cherry picked from commit 8084943)
stevanbz
added a commit
to stevanbz/alerting
that referenced
this pull request
Jan 17, 2023
opensearch-project#753) * Added document _id as param for terms query when searching alerts by their ids Signed-off-by: Stevan Buzejic <[email protected]> * Empty-Commit Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]>
stevanbz
added a commit
to stevanbz/alerting
that referenced
this pull request
Jan 17, 2023
opensearch-project#753) * Added document _id as param for terms query when searching alerts by their ids Signed-off-by: Stevan Buzejic <[email protected]> * Empty-Commit Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]>
eirsep
pushed a commit
that referenced
this pull request
Jan 17, 2023
#753) (#759) * Added document _id as param for terms query when searching alerts by their ids Signed-off-by: Stevan Buzejic <[email protected]> * Empty-Commit Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]>
eirsep
pushed a commit
that referenced
this pull request
Jan 17, 2023
#753) (#760) * Added document _id as param for terms query when searching alerts by their ids Signed-off-by: Stevan Buzejic <[email protected]> * Empty-Commit Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]> Signed-off-by: Stevan Buzejic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…their ids
Signed-off-by: Stevan Buzejic [email protected]
(#748)
Description of changes:
Changed the terms query used for getting the alerts to use the doc id (_id) instead of the alert id
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.