Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added document _id as param for terms query when searching alerts by … #753

Merged

Conversation

stevanbz
Copy link
Contributor

@stevanbz stevanbz commented Jan 12, 2023

…their ids

Signed-off-by: Stevan Buzejic [email protected]

(#748)

Description of changes:
Changed the terms query used for getting the alerts to use the doc id (_id) instead of the alert id
CheckList:
[ ] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Stevan Buzejic <[email protected]>
@codecov-commenter
Copy link

Codecov Report

Merging #753 (06e6d22) into main (780744f) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main     #753      +/-   ##
============================================
- Coverage     75.43%   75.29%   -0.15%     
  Complexity      116      116              
============================================
  Files           125      125              
  Lines          6828     6828              
  Branches       1024     1024              
============================================
- Hits           5151     5141      -10     
- Misses         1143     1155      +12     
+ Partials        534      532       -2     
Impacted Files Coverage Δ
...rch/alerting/transport/TransportGetAlertsAction.kt 75.51% <100.00%> (ø)
.../alerting/transport/TransportIndexMonitorAction.kt 54.93% <0.00%> (-2.97%) ⬇️
.../kotlin/org/opensearch/alerting/util/IndexUtils.kt 70.83% <0.00%> (-2.09%) ⬇️
...destinationmigration/DestinationConversionUtils.kt 70.00% <0.00%> (-1.12%) ⬇️
...ing/model/destination/DestinationContextFactory.kt 78.57% <0.00%> (+3.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep eirsep merged commit 8084943 into opensearch-project:main Jan 13, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 13, 2023
#753)

* Added document _id as param for terms query when searching alerts by their ids

Signed-off-by: Stevan Buzejic <[email protected]>

* Empty-Commit

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
(cherry picked from commit 8084943)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 13, 2023
#753)

* Added document _id as param for terms query when searching alerts by their ids

Signed-off-by: Stevan Buzejic <[email protected]>

* Empty-Commit

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
(cherry picked from commit 8084943)
stevanbz added a commit to stevanbz/alerting that referenced this pull request Jan 17, 2023
opensearch-project#753)

* Added document _id as param for terms query when searching alerts by their ids

Signed-off-by: Stevan Buzejic <[email protected]>

* Empty-Commit

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
stevanbz added a commit to stevanbz/alerting that referenced this pull request Jan 17, 2023
opensearch-project#753)

* Added document _id as param for terms query when searching alerts by their ids

Signed-off-by: Stevan Buzejic <[email protected]>

* Empty-Commit

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
eirsep pushed a commit that referenced this pull request Jan 17, 2023
#753) (#759)

* Added document _id as param for terms query when searching alerts by their ids

Signed-off-by: Stevan Buzejic <[email protected]>

* Empty-Commit

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
eirsep pushed a commit that referenced this pull request Jan 17, 2023
#753) (#760)

* Added document _id as param for terms query when searching alerts by their ids

Signed-off-by: Stevan Buzejic <[email protected]>

* Empty-Commit

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>

Signed-off-by: Stevan Buzejic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants