Fix error message bug to show the correct destination ID thats missing #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashish Agrawal <[email protected]>
lezzago
added
backport 1.x
backport 2.0
backport 1.3
backport 2.1
backport 2.x
backport 2.2
backport 2.3
backport 2.4
and removed
backport 1.x
backport 1.3
labels
getsaurabh02
approved these changes
Dec 19, 2022
bowenlan-amzn
approved these changes
Dec 20, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
#685) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
#685) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
#685) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
#685) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
#685) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 20, 2022
#685) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185)
khushbr
pushed a commit
that referenced
this pull request
Dec 21, 2022
#685) (#719) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185) Co-authored-by: Ashish Agrawal <[email protected]>
khushbr
pushed a commit
that referenced
this pull request
Dec 21, 2022
#685) (#720) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185) Co-authored-by: Ashish Agrawal <[email protected]>
khushbr
pushed a commit
that referenced
this pull request
Dec 21, 2022
#685) (#718) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185) Co-authored-by: Ashish Agrawal <[email protected]>
khushbr
pushed a commit
that referenced
this pull request
Dec 21, 2022
#685) (#717) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185) Co-authored-by: Ashish Agrawal <[email protected]>
khushbr
pushed a commit
that referenced
this pull request
Dec 21, 2022
#685) (#716) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185) Co-authored-by: Ashish Agrawal <[email protected]>
lezzago
added a commit
that referenced
this pull request
Jan 9, 2023
#685) (#715) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> (cherry picked from commit 2a1a185) Co-authored-by: Ashish Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ashish Agrawal [email protected]
Issue #, if available:
N/A
Description of changes:
When the destination or notification channel cannot be found, the error message shows the action Id instead of the destination/notification id.
CheckList:
[X] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.