Set message when building LegacyCustomWebhookMessage #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Petar Partlov <[email protected]>
qreshi
reviewed
Nov 10, 2022
| @@ -260,7 +260,7 @@ data class Destination( | |||
| } | |||
| DestinationType.CUSTOM_WEBHOOK -> { | |||
| destinationMessage = LegacyCustomWebhookMessage.Builder(name) | |||
| .withUrl(getLegacyCustomWebhookMessageURL(customWebhook)) | |||
| .withUrl(getLegacyCustomWebhookMessageURL(customWebhook, compiledMessage)) | |||
| .withHeaderParams(customWebhook?.headerParams) | |||
| .withMessage(compiledMessage).build() | |||
There was a problem hiding this comment.
The message is passed in here. It's not required in getLegacyCustomWebhookMessageURL since that method is only combining the individual URL parameters to a String to pass to withUrl.
There was a problem hiding this comment.
Ah, I see what you're saying. We're not setting message in the builder and it's throwing an IllegalArgumentException when we call build() in getLegacyCustomWebhookMessageURL()?
There was a problem hiding this comment.
Yes that is correct. It is true that it is not required for actual construction of URI, but unfortunately it is required field of LegacyCustomWebhookMessage and it always throws IllegalArgumentException("Message content is missing"). I went with this solution as it is simple and this legacy destination is only used in limited number of cases (and it will probably be removed in some of future releases).
It would probably be best to completely separate URI construction code of constructing LegacyCustomWebhookMessage object itself, but as message is available here I went with this easy fix.
lezzago
approved these changes
Dec 1, 2022
qreshi
approved these changes
Dec 1, 2022
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 1, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588)
lezzago
pushed a commit
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588) Co-authored-by: Petar Partlov <[email protected]>
lezzago
pushed a commit
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588) Co-authored-by: Petar Partlov <[email protected]>
lezzago
pushed a commit
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588) Co-authored-by: Petar Partlov <[email protected]>
lezzago
pushed a commit
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588) Co-authored-by: Petar Partlov <[email protected]>
lezzago
pushed a commit
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588) Co-authored-by: Petar Partlov <[email protected]>
lezzago
pushed a commit
that referenced
this pull request
Dec 20, 2022
Signed-off-by: Petar Partlov <[email protected]> Signed-off-by: Petar Partlov <[email protected]> (cherry picked from commit 9d9f588) Co-authored-by: Petar Partlov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Petar Partlov [email protected]
Issue #, if available:
Description of changes:
While testing legacy destinations for custom webhooks I discovered issue which is 100% reproducible. Scope should not be huge as this can influence only users with some issue during migration of old legacy notification system to new which uses notification plugin.
Issue is that one of required field (message) was not set during building instance of LegacyCustomWebhookMessage object.
CheckList:
[ ] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.