Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bucket level monitor findings to support term aggs in query #666

Merged
merged 1 commit into from
Nov 9, 2022

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Nov 8, 2022

Signed-off-by: Surya Sashank Nistala [email protected]

CheckList:
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@eirsep eirsep requested a review from a team November 8, 2022 23:44
@codecov-commenter
Copy link

Codecov Report

Merging #666 (c56df76) into main (1018fa2) will increase coverage by 0.04%.
The diff coverage is 82.22%.

@@             Coverage Diff              @@
##               main     #666      +/-   ##
============================================
+ Coverage     75.98%   76.03%   +0.04%     
  Complexity      116      116              
============================================
  Files           124      124              
  Lines          6580     6606      +26     
  Branches        974      980       +6     
============================================
+ Hits           5000     5023      +23     
- Misses         1086     1087       +1     
- Partials        494      496       +2     
Impacted Files Coverage Δ
...opensearch/alerting/util/DocLevelMonitorQueries.kt 80.00% <81.25%> (+0.45%) ⬆️
...rg/opensearch/alerting/BucketLevelMonitorRunner.kt 79.56% <82.75%> (+0.39%) ⬆️
...destinationmigration/DestinationConversionUtils.kt 70.00% <0.00%> (-1.12%) ⬇️
...nationmigration/DestinationMigrationUtilService.kt 81.45% <0.00%> (-0.81%) ⬇️
...ain/kotlin/org/opensearch/alerting/AlertService.kt 79.06% <0.00%> (+0.46%) ⬆️
...ensearch/alerting/util/AggregationQueryRewriter.kt 74.35% <0.00%> (+2.56%) ⬆️
...ing/model/destination/DestinationContextFactory.kt 78.57% <0.00%> (+3.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eirsep eirsep merged commit 0fb9dd0 into opensearch-project:main Nov 9, 2022
@eirsep eirsep deleted the findings-fix branch November 9, 2022 00:06
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 9, 2022
Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 0fb9dd0)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 9, 2022
Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 0fb9dd0)
eirsep added a commit that referenced this pull request Nov 9, 2022
#667)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 0fb9dd0)

Co-authored-by: Surya Sashank Nistala <[email protected]>
eirsep added a commit that referenced this pull request Nov 9, 2022
#668)

Signed-off-by: Surya Sashank Nistala <[email protected]>
(cherry picked from commit 0fb9dd0)

Co-authored-by: Surya Sashank Nistala <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants