Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds owner field in monitor model #579

Merged
merged 7 commits into from
Oct 3, 2022
Merged

Conversation

eirsep
Copy link
Member

@eirsep eirsep commented Sep 29, 2022

Signed-off-by: Surya Sashank Nistala [email protected]

Issue #, if available:
#576

Signed-off-by: Surya Sashank Nistala <[email protected]>
@eirsep eirsep requested a review from a team September 29, 2022 17:22
@eirsep eirsep marked this pull request as draft September 29, 2022 17:22
@codecov-commenter
Copy link

codecov-commenter commented Sep 29, 2022

Codecov Report

Merging #579 (3eeb9b6) into main (3a844f8) will increase coverage by 0.19%.
The diff coverage is 92.30%.

@@             Coverage Diff              @@
##               main     #579      +/-   ##
============================================
+ Coverage     76.85%   77.05%   +0.19%     
  Complexity      178      178              
============================================
  Files           167      167              
  Lines          8556     8567      +11     
  Branches       1268     1269       +1     
============================================
+ Hits           6576     6601      +25     
+ Misses         1346     1331      -15     
- Partials        634      635       +1     
Impacted Files Coverage Δ
...in/kotlin/org/opensearch/alerting/model/Monitor.kt 86.55% <90.00%> (+0.04%) ⬆️
...rch/alerting/resthandler/RestIndexMonitorAction.kt 81.66% <100.00%> (+0.96%) ⬆️
...nationmigration/DestinationMigrationUtilService.kt 82.25% <0.00%> (+0.80%) ⬆️
...destinationmigration/DestinationConversionUtils.kt 72.22% <0.00%> (+1.11%) ⬆️
.../kotlin/org/opensearch/alerting/util/IndexUtils.kt 72.91% <0.00%> (+2.08%) ⬆️
.../alerting/transport/TransportIndexMonitorAction.kt 71.42% <0.00%> (+3.13%) ⬆️
...ing/model/destination/DestinationContextFactory.kt 78.57% <0.00%> (+3.57%) ⬆️
...nationmigration/DestinationMigrationCoordinator.kt 68.08% <0.00%> (+4.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Surya Sashank Nistala <[email protected]>
@eirsep eirsep marked this pull request as ready for review September 30, 2022 18:10
@eirsep eirsep changed the title adds owner field in monitor model Adds owner field in monitor model Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants