-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cluster metrics visualization #509
Cluster metrics visualization #509
Conversation
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Codecov Report
@@ Coverage Diff @@
## cluster-metrics-visualization-dev #509 +/- ##
=======================================================================
+ Coverage 76.72% 77.23% +0.50%
- Complexity 176 179 +3
=======================================================================
Files 166 169 +3
Lines 8370 8658 +288
Branches 1232 1254 +22
=======================================================================
+ Hits 6422 6687 +265
- Misses 1343 1345 +2
- Partials 605 626 +21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
…changes. Signed-off-by: Richard <[email protected]>
…changes. Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
alerting/src/main/kotlin/org/opensearch/alerting/AlertingPlugin.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/AlertingPlugin.kt
Outdated
Show resolved
Hide resolved
alerting/src/main/kotlin/org/opensearch/alerting/settings/AlertingSettings.kt
Show resolved
Hide resolved
ExecutionValidator(), | ||
Setting.Property.NodeScope, Setting.Property.Dynamic | ||
) | ||
internal class ExecutionValidator : Setting.Validator<TimeValue> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll want to extract your validation logic into a separate, helper file. That will help prevent the AlertingSettings
file from becoming clogged with feature-specific validators.
alerting/src/main/kotlin/org/opensearch/alerting/settings/AlertingSettings.kt
Show resolved
Hide resolved
...in/org/opensearch/alerting/util/clustermetricscoordinatortest/ClusterMetricsCoordinatorIT.kt
Show resolved
Hide resolved
...in/org/opensearch/alerting/util/clustermetricscoordinatortest/ClusterMetricsCoordinatorIT.kt
Outdated
Show resolved
Hide resolved
...in/org/opensearch/alerting/util/clustermetricscoordinatortest/ClusterMetricsCoordinatorIT.kt
Outdated
Show resolved
Hide resolved
...in/org/opensearch/alerting/util/clustermetricscoordinatortest/ClusterMetricsCoordinatorIT.kt
Show resolved
Hide resolved
...in/org/opensearch/alerting/util/clustermetricscoordinatortest/ClusterMetricsCoordinatorIT.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Currently merging in this PR to the dev branch as to not lose this work and we can come back to it if we want this in the production version of Alerting. |
5e8c01c
into
opensearch-project:cluster-metrics-visualizations-dev
Description of changes:
The backend portion of my intern project. Created new classes and coordinators so that data collection and deletion jobs begin upon startup of the alerting plugin.
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.