Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cluster metrics visualization #509

Conversation

richfuAWS
Copy link

Description of changes:
The backend portion of my intern project. Created new classes and coordinators so that data collection and deletion jobs begin upon startup of the alerting plugin.

CheckList:
[x] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

richfuAWS and others added 30 commits July 7, 2022 13:01
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
Signed-off-by: Richard <[email protected]>
@AWSHurneyt
Copy link
Collaborator

AWSHurneyt commented Aug 9, 2022

Looks like your PR includes the commits that refactored the backwards compatibility tests to use OS 1.1 instead of ODFE. This development branch in the public repo is 1 commit behind the main branch. I created these PRs to sync them #517, #519.

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #509 (5a2d1f5) into cluster-metrics-visualization-dev (3b8bfe7) will increase coverage by 0.50%.
The diff coverage is 84.48%.

❗ Current head 5a2d1f5 differs from pull request most recent head 6f5c6f1. Consider uploading reports for the commit 6f5c6f1 to get more accurate results

@@                           Coverage Diff                           @@
##             cluster-metrics-visualization-dev     #509      +/-   ##
=======================================================================
+ Coverage                                76.72%   77.23%   +0.50%     
- Complexity                                 176      179       +3     
=======================================================================
  Files                                      166      169       +3     
  Lines                                     8370     8658     +288     
  Branches                                  1232     1254      +22     
=======================================================================
+ Hits                                      6422     6687     +265     
- Misses                                    1343     1345       +2     
- Partials                                   605      626      +21     
Impacted Files Coverage Δ
...nationmigration/DestinationMigrationCoordinator.kt 68.08% <ø> (+4.25%) ⬆️
.../alerting/util/ClusterMetricsVisualizationIndex.kt 63.63% <63.63%> (ø)
...g/opensearch/alerting/settings/AlertingSettings.kt 91.42% <77.55%> (-7.48%) ⬇️
...nsearch/alerting/util/ClusterMetricsCoordinator.kt 85.36% <85.36%> (ø)
...n/kotlin/org/opensearch/alerting/AlertingPlugin.kt 92.77% <85.71%> (-0.74%) ⬇️
...ensearch/alerting/model/ClusterMetricsDataPoint.kt 100.00% <100.00%> (ø)
...rg/opensearch/alerting/BucketLevelMonitorRunner.kt 76.15% <0.00%> (-0.77%) ⬇️
...ain/kotlin/org/opensearch/alerting/AlertService.kt 78.46% <0.00%> (+0.47%) ⬆️
...destinationmigration/DestinationConversionUtils.kt 71.11% <0.00%> (+1.11%) ⬆️
.../kotlin/org/opensearch/alerting/util/IndexUtils.kt 72.91% <0.00%> (+2.08%) ⬆️
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ExecutionValidator(),
Setting.Property.NodeScope, Setting.Property.Dynamic
)
internal class ExecutionValidator : Setting.Validator<TimeValue> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll want to extract your validation logic into a separate, helper file. That will help prevent the AlertingSettings file from becoming clogged with feature-specific validators.

@AWSHurneyt AWSHurneyt changed the base branch from cluster-metrics-visualization-dev to cluster-metrics-visualizations-dev August 11, 2022 22:50
@lezzago lezzago marked this pull request as ready for review January 19, 2023 18:42
@lezzago lezzago requested a review from a team January 19, 2023 18:42
@lezzago
Copy link
Member

lezzago commented Jan 19, 2023

Currently merging in this PR to the dev branch as to not lose this work and we can come back to it if we want this in the production version of Alerting.

@lezzago lezzago merged commit 5e8c01c into opensearch-project:cluster-metrics-visualizations-dev Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants