Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Security Integration tests #326

Closed
wants to merge 3 commits into from
Closed

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Mar 8, 2022

Issue #, if available:
#300
Description of changes:
Fix Security integ assertions
CheckList:
[X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago lezzago requested a review from a team March 8, 2022 20:23
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2022

Codecov Report

Merging #326 (dd8d3ac) into main (5f18a5c) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #326      +/-   ##
============================================
- Coverage     78.59%   78.53%   -0.06%     
+ Complexity      218      217       -1     
============================================
  Files           173      173              
  Lines          6975     6975              
  Branches        916      916              
============================================
- Hits           5482     5478       -4     
- Misses         1005     1009       +4     
  Partials        488      488              
Impacted Files Coverage Δ
...ing/destination/client/DestinationEmailClient.java 72.50% <0.00%> (-5.00%) ⬇️
...ing/model/destination/DestinationContextFactory.kt 66.66% <0.00%> (-3.71%) ⬇️
.../kotlin/org/opensearch/alerting/core/JobSweeper.kt 71.50% <0.00%> (-0.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f18a5c...dd8d3ac. Read the comment docs.

Signed-off-by: Ashish Agrawal <[email protected]>
lezzago added 2 commits March 8, 2022 14:25
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
@lezzago lezzago closed this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants