-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport removal of runBlocking and Stats API fix #284
Backport removal of runBlocking and Stats API fix #284
Conversation
* Remove runBlocking calls from MonitorRunner Signed-off-by: Mohammad Qureshi <[email protected]> * Add security tests with partial user permissions to check user context being correctly applied Signed-off-by: Mohammad Qureshi <[email protected]> * Fix ktlint style issues Signed-off-by: Mohammad Qureshi <[email protected]>
…response (opensearch-project#283) * Add back opendistro prefixed sweeper enabled to alerting stats response Signed-off-by: Mohammad Qureshi <[email protected]> * Rename stats response field variables used in tests Signed-off-by: Mohammad Qureshi <[email protected]>
35a814f
to
1c27c67
Compare
Codecov Report
@@ Coverage Diff @@
## 1.2 #284 +/- ##
============================================
+ Coverage 78.45% 78.63% +0.17%
- Complexity 211 214 +3
============================================
Files 173 173
Lines 6959 6964 +5
Branches 912 912
============================================
+ Hits 5460 5476 +16
+ Misses 1017 1003 -14
- Partials 482 485 +3
Continue to review full report at Codecov.
|
8f3d2ae
to
dfd73ec
Compare
Judging from the GitHub Action run results from the original PR of this change on Because of this, I ended up using this PR to debug the security tests written for this change since they weren't actually passing. I'm able to get a clean pass now but I'm going to force push this PR to not include the recent changes so I can submit the change as a follow-up PR from |
dfd73ec
to
1c27c67
Compare
Issue #, if available:
Description of changes:
Backport #281 and #283 to
1.2
CheckList:
[x] Commits are signed per the DCO using --signoff
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.