Upgrade to upload-artifact v4 #1739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Craig Perkins <[email protected]>
cwperks
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya,
engechas,
riysaxen-amzn,
jowg-amazon,
amsiglan and
goyamegh
as code owners
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
AWSHurneyt
approved these changes
Dec 5, 2024
jowg-amazon
approved these changes
Dec 5, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1739-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3747b5648bca8c4c572e9a45a0bb21009f6fc24f
# Push it to GitHub
git push --set-upstream origin backport-1739-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.xThen, create a pull request where the |
|
I'll create a backport for this |
AWSHurneyt
pushed a commit
that referenced
this pull request
Dec 5, 2024
* Upgrade to upload-artifact v4 Signed-off-by: Craig Perkins <[email protected]> * Upgrade actions/checkout to v4 Signed-off-by: Craig Perkins <[email protected]> * Add run-start-commands Signed-off-by: Craig Perkins <[email protected]> * Set overwrite to true Signed-off-by: Craig Perkins <[email protected]> * Only run with jdk 21 Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]> (cherry picked from commit 3747b56)
sbcd90
pushed a commit
to sbcd90/alerting
that referenced
this pull request
Dec 11, 2024
* Upgrade to upload-artifact v4 Signed-off-by: Craig Perkins <[email protected]> * Upgrade actions/checkout to v4 Signed-off-by: Craig Perkins <[email protected]> * Add run-start-commands Signed-off-by: Craig Perkins <[email protected]> * Set overwrite to true Signed-off-by: Craig Perkins <[email protected]> * Only run with jdk 21 Signed-off-by: Craig Perkins <[email protected]> --------- Signed-off-by: Craig Perkins <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Upgrades to actions/upload-artifact@v4 to resolve CI issues
Related Issues
Resolves #1726
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.