Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Destination converter for Notification Channels and utility class to call Notification API #137

Closed
wants to merge 0 commits into from

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented Aug 8, 2021

Issue #, if available:
#105
Description of changes:

  • Add Destination converter for Notification Channels
  • Add utility class to call Notification API
    CheckList:
    [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago lezzago requested a review from adityaj1107 August 8, 2021 23:04
@codecov-commenter
Copy link

Codecov Report

Merging #137 (1c45a2c) into main (ff57c54) will decrease coverage by 1.64%.
The diff coverage is 58.92%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #137      +/-   ##
============================================
- Coverage     80.46%   78.82%   -1.65%     
+ Complexity      215      214       -1     
============================================
  Files           154      158       +4     
  Lines          5873     6338     +465     
  Branches        706      755      +49     
============================================
+ Hits           4726     4996     +270     
- Misses          768      932     +164     
- Partials        379      410      +31     
Impacted Files Coverage Δ
...g/opensearch/alerting/util/NotificationAPIUtils.kt 0.00% <0.00%> (ø)
...pensearch/alerting/elasticapi/ElasticExtensions.kt 42.85% <0.00%> (-9.07%) ⬇️
...ng/actionconverter/EmailAccountActionsConverter.kt 76.47% <76.47%> (ø)
...ing/actionconverter/DestinationActionsConverter.kt 80.66% <80.66%> (ø)
...ting/actionconverter/EmailGroupActionsConverter.kt 86.44% <86.44%> (ø)
...ing/destination/client/DestinationEmailClient.java 72.50% <0.00%> (-5.00%) ⬇️
.../kotlin/org/opensearch/alerting/util/IndexUtils.kt 72.09% <0.00%> (-2.33%) ⬇️
.../kotlin/org/opensearch/alerting/core/JobSweeper.kt 71.72% <0.00%> (-0.53%) ⬇️
...ing/model/destination/DestinationContextFactory.kt 66.66% <0.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff57c54...1c45a2c. Read the comment docs.

return GetNotificationConfigRequest(configIds, fromIndex, maxItems, sortField, sortOrder, filterParams)
}

fun convertGetNotificationConfigResponseToGetDestinationsResponse(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we mark this as internal as well, Since it is also being used inside another function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants