fix fieldLimit exception in docLevelMonitor #1368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riya Saxena <[email protected]>
riysaxen-amzn
requested review from
lezzago,
AWSHurneyt,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
eirsep
reviewed
Jan 6, 2024
eirsep
reviewed
Jan 6, 2024
| logger.error("Error setting up alerts and findings indices for monitor: $id", e) | ||
| monitorResult = monitorResult.copy(error = AlertingException.wrap(e)) | ||
| val unwrappedException = ExceptionsHelper.unwrapCause(e) as Exception | ||
| if (unwrappedException is IllegalArgumentException && unwrappedException.message?.contains("Limit of total fields") == true) { |
There was a problem hiding this comment.
if you unwrap and cast to generic Exception how will this check unwrappedException is IllegalArgumentException be true ever?
eirsep
reviewed
Jan 6, 2024
| if (unwrappedException is IllegalArgumentException && unwrappedException.message?.contains("Limit of total fields") == true) { | ||
| val errorMessage = | ||
| "Monitor [$id] can't process index [$monitor.dataSources] due to field mapping limit" | ||
| logger.error(errorMessage) |
There was a problem hiding this comment.
we can pass a custom message to user but can we log the original exception here instead?
|
NIT: plz rename the PR title to |
praveensameneni
approved these changes
Jan 6, 2024
Signed-off-by: Riya Saxena <[email protected]>
engechas
approved these changes
Apr 4, 2024
| val errorMessage = | ||
| "Monitor [$id] can't process index [$monitor.dataSources] due to field mapping limit" | ||
| logger.error("Exception: ${unwrappedException.message}") | ||
| monitorResult = monitorResult.copy(error = AlertingException(errorMessage, RestStatus.INTERNAL_SERVER_ERROR, e)) |
There was a problem hiding this comment.
A 4XX (maybe 400) would be more appropriate here than a 500 imo since the field limit getting hit is from user behavior rather than an internal server error
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
* fix fieldLimit exception in docLevelMonitor Signed-off-by: Riya Saxena <[email protected]> * bug fixes from prev pr Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 77fc8b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
* fix fieldLimit exception in docLevelMonitor Signed-off-by: Riya Saxena <[email protected]> * bug fixes from prev pr Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 77fc8b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Apr 19, 2024
* fix fieldLimit exception in docLevelMonitor * bug fixes from prev pr --------- (cherry picked from commit 77fc8b6) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Apr 19, 2024
* fix fieldLimit exception in docLevelMonitor * bug fixes from prev pr --------- (cherry picked from commit 77fc8b6) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 2, 2024
* fix fieldLimit exception in docLevelMonitor Signed-off-by: Riya Saxena <[email protected]> * bug fixes from prev pr Signed-off-by: Riya Saxena <[email protected]> --------- Signed-off-by: Riya Saxena <[email protected]> (cherry picked from commit 77fc8b6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
jowg-amazon
pushed a commit
that referenced
this pull request
May 2, 2024
* fix fieldLimit exception in docLevelMonitor * bug fixes from prev pr --------- (cherry picked from commit 77fc8b6) Signed-off-by: Riya Saxena <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#825
Resurface actual field limit error in DocLevelMonitorRunner when updating index Mappings
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.