fix workflow execution for first run #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbcd90
requested review from
lezzago,
AWSHurneyt,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
eirsep
reviewed
Oct 3, 2023
| }""" | ||
|
|
||
| indexDoc(index, "1", testDoc) | ||
| Thread.sleep(80000) |
There was a problem hiding this comment.
NIT: adding 80 second sleeps makes tests flaky and long running we should try simulate 1 second interval jobs
can you change this to create workflow with periodicty of 1 second and sleep for 5 or 10 seconds?
There was a problem hiding this comment.
we cannot change it to 1 second because the min frequency allowed is 1 min. we can remove the test always or mark as ignored.
eirsep
approved these changes
Oct 3, 2023
lezzago
reviewed
Oct 4, 2023
Comment on lines
408
to
406
| if (monitor.monitorType == Monitor.MonitorType.DOC_LEVEL_MONITOR) { | ||
| docLevelMonitorQueries.indexDocLevelMonitorQueries( | ||
| monitor, | ||
| monitor.id, | ||
| monitorMetadata, | ||
| request.refreshPolicy, | ||
| indexTimeout | ||
| ) | ||
| } |
There was a problem hiding this comment.
Why is this needed? This happens when the monitor is first created anyways.
Comment on lines
569
to
581
| client.suspendUntil<Client, BulkByScrollResponse> { | ||
| DeleteByQueryRequestBuilder(client, DeleteByQueryAction.INSTANCE) | ||
| .source(monitor.dataSources.queryIndex) | ||
| .filter(QueryBuilders.matchQuery("monitor_id", monitor.id)) | ||
| .execute(it) | ||
| } | ||
| docLevelMonitorQueries.indexDocLevelMonitorQueries( | ||
| monitor, | ||
| monitor.id, | ||
| updatedMetadata, | ||
| request.refreshPolicy, | ||
| indexTimeout | ||
| ) |
There was a problem hiding this comment.
why do we need to reindex the monitor queries?
| @@ -3151,7 +3151,7 @@ class MonitorDataSourcesIT : AlertingSingleNodeTestCase() { | |||
| } catch (ex: java.lang.Exception) { | |||
| exception = ex | |||
| } | |||
| assertTrue(exception is java.util.NoSuchElementException) | |||
| assertFalse(exception is java.util.NoSuchElementException) | |||
There was a problem hiding this comment.
Dont we want to move this into the catch and keep it as assertTrue?
Signed-off-by: Subhobrata Dey <[email protected]>
lezzago
approved these changes
Oct 4, 2023
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting/backport-2.x
# Create a new branch
git switch --create backport-1220-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f5fc62c79fd179efa1c424d94005cbdba9dea509
# Push it to GitHub
git push --set-upstream origin backport-1220-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting/backport-2.xThen, create a pull request where the |
1 task
amsiglan
pushed a commit
to amsiglan/alerting
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Subhobrata Dey <[email protected]>
1 task
lezzago
pushed a commit
that referenced
this pull request
Dec 6, 2023
Signed-off-by: Subhobrata Dey <[email protected]> Co-authored-by: Subhobrata Dey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
opensearch-project/security-analytics#606
Description of changes:
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.