Resolve compile issues from core changes and update CIs #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect#1025) Signed-off-by: Ashish Agrawal <[email protected]>
…#1062) * Resolve core Xcontent refactor Signed-off-by: Ashish Agrawal <[email protected]> * Resolve core CircuitBreaker refactor Signed-off-by: Ashish Agrawal <[email protected]> * Resolve integ test issues with adding test dependency Signed-off-by: Ashish Agrawal <[email protected]> --------- Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
lezzago
changed the title
|
Test are failing due to issues in |
AWSHurneyt
approved these changes
Aug 22, 2023
.github/workflows/test-workflow.yml
Outdated
| @@ -44,7 +42,7 @@ jobs: | |||
| java-version: ${{ matrix.java }} | |||
| - name: Build and run with Gradle | |||
| working-directory: ${{ env.WORKING_DIR }} | |||
| run: ./gradlew build ${{ env.BUILD_ARGS }} | |||
| run: ./gradlew build ${{ env.BUILD_ARGS }} -x alertingBwcCluster#fullRestartClusterTask -x alertingBwcCluster#mixedClusterTask -x alertingBwcCluster#oldVersionClusterTask0 -x alertingBwcCluster#oldVersionClusterTask1 -x alertingBwcCluster#rollingUpgradeClusterTask -x alertingBwcCluster#twoThirdsUpgradedClusterTask | |||
There was a problem hiding this comment.
I prefer to specify what to run ./gradlew assemble integTest instead of specify bunch of tests to not run
Signed-off-by: Ashish Agrawal <[email protected]>
sbcd90
approved these changes
Aug 23, 2023
These issues have been resolved |
eirsep
reviewed
Aug 23, 2023
| @@ -44,7 +42,7 @@ jobs: | |||
| java-version: ${{ matrix.java }} | |||
| - name: Build and run with Gradle | |||
| working-directory: ${{ env.WORKING_DIR }} | |||
| run: ./gradlew build ${{ env.BUILD_ARGS }} | |||
| run: ./gradlew assemble integTest ${{ env.BUILD_ARGS }} | |||
There was a problem hiding this comment.
I had used the remove argument before, so I will update main with this change as well.
eirsep
reviewed
Aug 23, 2023
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package org.opensearch.alerting.action |
There was a problem hiding this comment.
NIT: This test class is present in common utils along with the request class. We shouldn't have this here as these tests would break if anything is changed in common utils
There was a problem hiding this comment.
Oh this test was present in Alerting main here
eirsep
approved these changes
Aug 23, 2023
bowenlan-amzn
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Resolve compile issues from core changes that backported to 2.x from main and disable BWC tests for non-bwc CIs
Backports following PRs:
#1062, #1090, #1025
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.