-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temp refactor cluster metrics monitor suspendUntil() to get(). #1015
Merged
eirsep
merged 6 commits into
opensearch-project:main
from
AWSHurneyt:main_cluster_metrics_enh
Jul 12, 2023
Merged
Temp refactor cluster metrics monitor suspendUntil() to get(). #1015
eirsep
merged 6 commits into
opensearch-project:main
from
AWSHurneyt:main_cluster_metrics_enh
Jul 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cat/indices, and cat/shards. Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
…t() to receive responses. Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
requested review from
lezzago,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
qreshi,
bowenlan-amzn and
rishabhmaurya
as code owners
July 12, 2023 16:29
Signed-off-by: AWSHurneyt <[email protected]>
lezzago
approved these changes
Jul 12, 2023
AWSHurneyt
changed the title
Fixed cluster metrics ktlint errors on main branch.
Temp refactor cluster metrics monitor suspendUntil() to get().
Jul 12, 2023
eirsep
approved these changes
Jul 12, 2023
Codecov Report
@@ Coverage Diff @@
## main #1015 +/- ##
============================================
- Coverage 73.83% 72.21% -1.62%
Complexity 113 113
============================================
Files 158 160 +2
Lines 9326 10294 +968
Branches 1365 1570 +205
============================================
+ Hits 6886 7434 +548
- Misses 1743 1961 +218
- Partials 697 899 +202
|
For reference, the multi node tests started failing in PR #976 (comment). Continuing to investigate. |
AWSHurneyt
added a commit
to AWSHurneyt/OpenSearch-Alerting
that referenced
this pull request
Jul 12, 2023
…earch-project#1015) * Implemented support for configuring a cluster metrics monitor to call cat/indices, and cat/shards. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored executeTransportAction to use suspendUntil() instead of get() to receive responses. Signed-off-by: AWSHurneyt <[email protected]> * Fixed ktlint errors. Signed-off-by: AWSHurneyt <[email protected]> * Refactored API calls from suspendUntil() to get(). Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
main
branch.This PR does not need to be backported as the changes were included in the manual backports to the 2.x and 2.9 branches.
CheckList:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.