-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored code to account for notifications server features API change #916
Refactored code to account for notifications server features API change #916
Conversation
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #916 +/- ##
==========================================
- Coverage 48.69% 48.67% -0.02%
==========================================
Files 236 236
Lines 6845 6847 +2
Branches 996 996
==========================================
Hits 3333 3333
- Misses 3509 3511 +2
Partials 3 3 ☔ View full report in Codecov by Sentry. |
…ge (#916) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c239ded) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ge (#916) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c239ded) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.x
# Create a new branch
git switch --create backport-916-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c239ded7f5fe94984fedae7fae63157503bb8099
# Push it to GitHub
git push --set-upstream origin backport-916-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.x Then, create a pull request where the |
…ge (opensearch-project#916) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c239ded)
…ge (#916) (#966) Signed-off-by: Amardeepsingh Siglani <[email protected]> (cherry picked from commit c239ded) Co-authored-by: Amardeepsingh Siglani <[email protected]>
Description
Notifications dashboards server route for fetching features (
/api/notifications/features
) was updated in PR opensearch-project/dashboards-notifications#181 so that we can fetch the channel types for which the channels should be shown in options menu. This PR makes the required code changes in alerting to consume these updates in notification.NOTE: The changes in the dashboards-notifications PR 181 are required for the changes in this PR, else it will break alerting.
Issues Resolved
#795
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.