Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Removed "last updated by" sections from the UI. (#767) #787

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

AWSHurneyt
Copy link
Collaborator

Description

Manually backported PR #767

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 1bea77f)
@AWSHurneyt AWSHurneyt marked this pull request as ready for review October 25, 2023 17:46
@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #787 (ca2b119) into 2.x (b978789) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##              2.x     #787      +/-   ##
==========================================
- Coverage   49.84%   49.84%   -0.01%     
==========================================
  Files         232      232              
  Lines        6558     6556       -2     
  Branches      940      938       -2     
==========================================
- Hits         3269     3268       -1     
+ Misses       3286     3285       -1     
  Partials        3        3              

see 3 files with indirect coverage changes

Signed-off-by: AWSHurneyt <[email protected]>
@AWSHurneyt
Copy link
Collaborator Author

The failing monitor dashboard cypress test is being tracked as flaky in issue #415

The failing acknowledge alerts cypress test was a timeout issue.

@AWSHurneyt AWSHurneyt merged commit ce57d4e into opensearch-project:2.x Oct 25, 2023
7 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 15, 2023
…#787)

* Removed "last updated by" sections from the UI. (#767)

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 1bea77f)

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit ce57d4e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt added a commit to AWSHurneyt/alerting-dashboards-plugin that referenced this pull request Nov 15, 2023
…earch-project#767) (opensearch-project#787)

* Removed "last updated by" sections from the UI. (opensearch-project#767)

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 1bea77f)

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt added a commit to AWSHurneyt/alerting-dashboards-plugin that referenced this pull request Nov 22, 2023
…earch-project#767) (opensearch-project#787)

* Removed "last updated by" sections from the UI. (opensearch-project#767)

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 1bea77f)

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
amsiglan pushed a commit that referenced this pull request Apr 3, 2024
#802)

* Add 2.10.0 release notes (#707) (#711)

(cherry picked from commit 30b3b71)

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <[email protected]>

* [Backport 2.x] Removed "last updated by" sections from the UI. (#767) (#787)

* Removed "last updated by" sections from the UI. (#767)

* Removed "last updated by" section from the UI as the SearchMonitor API can no longer return that info.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 1bea77f)

* Updated cypress workflow.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>

* Updated cypress-workflow.yml.

Signed-off-by: AWSHurneyt <[email protected]>

* Adjusted test workflow references.

Signed-off-by: AWSHurneyt <[email protected]>

* Adjusted test workflow references.

Signed-off-by: AWSHurneyt <[email protected]>

* Adjusted test workflow references.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: AWSHurneyt <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants