[Backport 2.5] Temporary fix for blank monitor name on Monitors page issue. #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Refactored the cluster metrics monitor configuration component to not automatically execute the monitor dryrun when there are no triggers defined. Signed-off-by: AWSHurneyt <[email protected]> * Temporary fix for bug described in issue 569. Signed-off-by: AWSHurneyt <[email protected]> * Fixed display issue. Signed-off-by: AWSHurneyt <[email protected]> * Fixed unit test. Updated snapshots. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit c152885)
Codecov Report
@@ Coverage Diff @@
## 2.5 #602 +/- ##
==========================================
+ Coverage 52.73% 52.75% +0.02%
==========================================
Files 210 210
Lines 5486 5480 -6
Branches 765 768 +3
==========================================
- Hits 2893 2891 -2
+ Misses 2591 2587 -4
Partials 2 2 |
lezzago
approved these changes
Jul 19, 2023
AWSHurneyt
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport c152885 from #593