Fixed a bug with doc level trigger creation. #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etails. Signed-off-by: AWSHurneyt <[email protected]>
5 tasks
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #513 +/- ##
=======================================
Coverage 53.39% 53.40%
=======================================
Files 209 209
Lines 5501 5500 -1
Branches 775 774 -1
=======================================
Hits 2937 2937
+ Misses 2562 2561 -1
Partials 2 2 see 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
lezzago
approved these changes
Apr 4, 2023
amsiglan
reviewed
Apr 12, 2023
public/pages/CreateTrigger/containers/CreateTrigger/utils/formikToTrigger.js
Show resolved
Hide resolved
amsiglan
approved these changes
Apr 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…etails. (#513) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9)
This was referenced Apr 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…etails. (#513) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…etails. (#513) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…etails. (#513) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9)
This was referenced Apr 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…etails. (#513) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…etails. (#513) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…etails. (#513) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9)
This was referenced Apr 17, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 17, 2023
…etails. (#513) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9)
AWSHurneyt
added a commit
that referenced
this pull request
Apr 17, 2023
…etails. (#513) (#521) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9) Co-authored-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Apr 18, 2023
…etails. (opensearch-project#513) Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Apr 18, 2023
…etails. (opensearch-project#513) Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Apr 18, 2023
…etails. (opensearch-project#513) Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Apr 18, 2023
…etails. (opensearch-project#513) Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
added a commit
to AWSHurneyt/alerting-dashboards-plugin
that referenced
this pull request
Apr 18, 2023
…etails. (opensearch-project#513) Signed-off-by: AWSHurneyt <[email protected]>
This was referenced Apr 18, 2023
bowenlan-amzn
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Fixed a bug with doc level trigger creation. See issue 448 for more details. (#513) Signed-off-by: AWSHurneyt <[email protected]> * Updated test workflow dependency references. Signed-off-by: AWSHurneyt <[email protected]> * Updated test workflow dependency references. Signed-off-by: AWSHurneyt <[email protected]> * Updated test workflow dependency references. Signed-off-by: AWSHurneyt <[email protected]> * Adjusted package versions used by tests. Signed-off-by: AWSHurneyt <[email protected]> * Adjusted package versions used by tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Fixed a bug with doc level trigger creation. See issue 448 for more details. (#513) Signed-off-by: AWSHurneyt <[email protected]> * Updated test workflow dependency references. Signed-off-by: AWSHurneyt <[email protected]> * Adjusted package versions used by tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Apr 26, 2023
…etails. (#513) (#524) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9) Co-authored-by: AWSHurneyt <[email protected]>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Apr 26, 2023
* Fixed a bug with doc level trigger creation. See issue 448 for more details. (#513) Signed-off-by: AWSHurneyt <[email protected]> * Updated test workflow dependency references. Signed-off-by: AWSHurneyt <[email protected]> * Updated test workflow dependency references. Signed-off-by: AWSHurneyt <[email protected]> * Adjusted package versions used by tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Apr 26, 2023
…etails. (#513) (#522) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9) Co-authored-by: AWSHurneyt <[email protected]>
bowenlan-amzn
pushed a commit
that referenced
this pull request
Apr 26, 2023
…etails. (#513) (#520) Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 45ea4b9) Co-authored-by: AWSHurneyt <[email protected]>
lezzago
pushed a commit
that referenced
this pull request
Apr 27, 2023
* Fixed a bug with doc level trigger creation. See issue 448 for more details. (#513) Signed-off-by: AWSHurneyt <[email protected]> * Updated test workflow dependency references. Signed-off-by: AWSHurneyt <[email protected]> * Updated test workflow dependency references. Signed-off-by: AWSHurneyt <[email protected]> * Adjusted package versions used by tests. Signed-off-by: AWSHurneyt <[email protected]> * Adjusted package versions used by tests. Signed-off-by: AWSHurneyt <[email protected]> --------- Signed-off-by: AWSHurneyt <[email protected]>
mjsell1234
pushed a commit
to mjsell1234/alerting-dashboards-plugin
that referenced
this pull request
Jun 14, 2023
…etails. (opensearch-project#513) Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a bug with doc level trigger creation.
As illustrated by the screenshot below, users can select whether they want the field value to equal the query value (by selecting
is), not equal the query value (by selectingis not), etc. The operator doesn't need to be configured in the trigger because it's already configured in the query itself. Essentially we just want the triggers to evaluate whether the document matches the query; and that query could be checking whether a field value equals or does not equal the query value. Adding theoperatorto thescriptSourceContentswas preventing the backend from determining whether the document matched the query.Issues Resolved
#448
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.