Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Keep monitor table cell width flexible; Check for whether monitor is enabled when displaying related action #416

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bd62a0b from #402

…enabled when displaying related action (#402)

* made table cells flexible; added monitor enabled check for actions

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshot

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* minor updates

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated jest snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit bd62a0b)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team December 9, 2022 21:28
@codecov-commenter
Copy link

codecov-commenter commented Dec 9, 2022

Codecov Report

Merging #416 (bd62a0b) into 2.x (d3047e9) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head bd62a0b differs from pull request most recent head 4fa7303. Consider uploading reports for the commit 4fa7303 to get more accurate results

@@            Coverage Diff             @@
##              2.x     #416      +/-   ##
==========================================
- Coverage   52.62%   52.58%   -0.04%     
==========================================
  Files         209      209              
  Lines        5469     5471       +2     
  Branches      765      765              
==========================================
- Hits         2878     2877       -1     
- Misses       2589     2592       +3     
  Partials        2        2              
Impacted Files Coverage Δ
...s/Monitors/containers/Monitors/utils/tableUtils.js 20.00% <0.00%> (-2.23%) ⬇️
...lic/pages/Monitors/containers/Monitors/Monitors.js 88.57% <0.00%> (-1.03%) ⬇️
...tificationsInfoCallOut/NotificationsInfoCallOut.js 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amsiglan amsiglan merged commit 8282ddf into 2.x Dec 12, 2022
@amsiglan amsiglan deleted the backport/backport-402-to-2.x branch December 12, 2022 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants