Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align all flyout components to be overlay kind and add close button X in header #373

Conversation

djindjic
Copy link
Contributor

@djindjic djindjic commented Nov 30, 2022

Description

Refactored all Flyout's to be as type="overlay" (default type value)

Issues Resolved

Resolves #296 #297 #298 #299 #300

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@djindjic djindjic requested a review from a team November 30, 2022 19:05
Signed-off-by: Aleksandar Djindjic <[email protected]>
@djindjic djindjic force-pushed the feature/refactor-flyouts-to-overlay branch from 559d4dd to 5b25146 Compare November 30, 2022 19:11
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
@djindjic djindjic force-pushed the feature/refactor-flyouts-to-overlay branch from 88321f2 to ad532bc Compare December 1, 2022 16:02
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2022

Codecov Report

Merging #373 (983f7d2) into main (6287bd5) will decrease coverage by 0.10%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #373      +/-   ##
==========================================
- Coverage   52.68%   52.57%   -0.11%     
==========================================
  Files         207      207              
  Lines        5444     5459      +15     
  Branches      764      766       +2     
==========================================
+ Hits         2868     2870       +2     
- Misses       2574     2587      +13     
  Partials        2        2              
Impacted Files Coverage Δ
...oard/components/FindingsDashboard/FindingFlyout.js 33.33% <0.00%> (-2.39%) ⬇️
...er/containers/ConfigureActions/ConfigureActions.js 6.72% <0.00%> (-0.69%) ⬇️
...erting-dashboards-plugin/public/utils/constants.js 100.00% <0.00%> (ø)
...gin/public/pages/Dashboard/containers/Dashboard.js 56.02% <0.00%> (ø)
...ic/pages/CreateTrigger/components/Action/Action.js 48.00% <0.00%> (ø)
.../pages/MonitorDetails/containers/MonitorDetails.js 0.00% <0.00%> (ø)
...eMonitor/containers/CreateMonitor/CreateMonitor.js 59.83% <0.00%> (ø)
...oard/components/FindingsDashboard/findingsUtils.js 56.92% <0.00%> (ø)
...s/AcknowledgeAlertsModal/AcknowledgeAlertsModal.js 1.83% <0.00%> (ø)
...ateMonitor/components/VisualGraph/utils/helpers.js 96.80% <0.00%> (+0.03%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@djindjic djindjic changed the title Align all flyout components to be overlay kind Align all flyout components to be overlay kind and add close button X in header Dec 1, 2022
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
@djindjic djindjic force-pushed the feature/refactor-flyouts-to-overlay branch from 400a2f1 to de66fc4 Compare December 2, 2022 15:43
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
@AWSHurneyt AWSHurneyt merged commit bcfe119 into opensearch-project:main Dec 6, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 6, 2022
… in header (#373)

* align all flyout components to overlay

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify if statement

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add close button to flyout header, remove footer

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify flex layout

Signed-off-by: Aleksandar Djindjic <[email protected]>

* update snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add data-test-subject on flyout header title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix cypress tests, overflow on flyout title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* eui-textTruncate on flyout titles

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit bcfe119)
amsiglan pushed a commit that referenced this pull request Dec 8, 2022
… in header (#373) (#399)

* align all flyout components to overlay

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify if statement

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add close button to flyout header, remove footer

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify flex layout

Signed-off-by: Aleksandar Djindjic <[email protected]>

* update snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add data-test-subject on flyout header title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix cypress tests, overflow on flyout title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* eui-textTruncate on flyout titles

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit bcfe119)

Co-authored-by: Aleksandar Djindjic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Dec 21, 2022
… in header (#373)

* align all flyout components to overlay

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify if statement

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add close button to flyout header, remove footer

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify flex layout

Signed-off-by: Aleksandar Djindjic <[email protected]>

* update snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add data-test-subject on flyout header title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix cypress tests, overflow on flyout title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* eui-textTruncate on flyout titles

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit bcfe119)
lezzago pushed a commit that referenced this pull request Dec 21, 2022
… in header (#373) (#427)

* align all flyout components to overlay

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify if statement

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add close button to flyout header, remove footer

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify flex layout

Signed-off-by: Aleksandar Djindjic <[email protected]>

* update snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add data-test-subject on flyout header title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix cypress tests, overflow on flyout title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* eui-textTruncate on flyout titles

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>
(cherry picked from commit bcfe119)

Co-authored-by: Aleksandar Djindjic <[email protected]>
lezzago added a commit that referenced this pull request Feb 13, 2023
* Bumped version from 2.3 to 2.4. (#346)

* Bumping version from 2.3 to 2.4.

Signed-off-by: AWSHurneyt <[email protected]>

* Adjusted OSD version used by unit test workflow to last version that allowed the tests to pass.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* Bumped d3-color version. (#350)

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* Support windows CI (#354)

* Support windows CI

Signed-off-by: Ashish Agrawal <[email protected]>

Signed-off-by: Ashish Agrawal <[email protected]>

* Add 2.4 release notes (#357)

Signed-off-by: Ashish Agrawal <[email protected]>

Signed-off-by: Ashish Agrawal <[email protected]>

* Fix confidence bug (#360)

This PR fixed a bug when showing confidence in trigger definition. Confidence is usually a non-decreasing function on an interval. But we incorrectly only show confidence when the corresponding anomaly grade is larger than 0.

Testing done:
1. manually tested that the bug is fixed. See attached snapshots.
2. yarn test:jest

Signed-off-by: Kaituo Li <[email protected]>

* Bumped loader-utils version to address dependabot alert. (#361)

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* updated link to dashboards developer guide (#349)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Fixed a bug that prevented the throttling settings from displaying for PER_ALERT bucket level trigger actions. (#328)

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* Adjust OpenSearch-Dashboards version used by test workflows. (#363)

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* avoid nesting search inside search (#382)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Bumped loader-utils version to address dependabot alert. (#379)

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* [BUG] Issues in the UI above 200 destinations paging issue #195 (#375)

* [BUG] Issues in the UI above 200 destinations #195

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Issues in the UI above 200 destinations #195

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Issues in the UI above 200 destinations #195

Signed-off-by: Jovan Cvetkovic <[email protected]>

Signed-off-by: Jovan Cvetkovic <[email protected]>

* sorted data by date (#385)

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Align all flyout components to be overlay kind and add close button X in header (#373)

* align all flyout components to overlay

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify if statement

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add close button to flyout header, remove footer

Signed-off-by: Aleksandar Djindjic <[email protected]>

* simplify flex layout

Signed-off-by: Aleksandar Djindjic <[email protected]>

* update snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* add data-test-subject on flyout header title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix cypress tests, overflow on flyout title

Signed-off-by: Aleksandar Djindjic <[email protected]>

* fix snapshot

Signed-off-by: Aleksandar Djindjic <[email protected]>

* eui-textTruncate on flyout titles

Signed-off-by: Aleksandar Djindjic <[email protected]>

Signed-off-by: Aleksandar Djindjic <[email protected]>

* Bumped decode-uri-component version to address CVE-2022-38900. (#400)

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed an issue that was causing the results of the ctx object to be empty.  (#334)

* Fixed an issue that was causing the results of the ctx object to be empty.

Signed-off-by: AWSHurneyt <[email protected]>

* Fixed an issue that was causing the results of the ctx object to be empty.

Signed-off-by: AWSHurneyt <[email protected]>

* Consolidated duplicate code.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* Keep monitor table cell width flexible; Check for whether monitor is enabled when displaying related action (#402)

* made table cells flexible; added monitor enabled check for actions

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated snapshot

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* minor updates

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* updated jest snapshots

Signed-off-by: Amardeepsingh Siglani <[email protected]>

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* Add release notes for 2.4.1 (#420)

Signed-off-by: Saurabh Singh <[email protected]>

Signed-off-by: Saurabh Singh <[email protected]>

* Bumped version to 2.5. (#437)

* Bumped version to 2.5.

Signed-off-by: AWSHurneyt <[email protected]>

* Adjusted test workflows to not use 2.5 tag for OSD as it hasn't been created yet.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* 2.5.0 release notes. (#440)

* Drafted 2.5 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

* Drafted 2.5 release notes.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation. (#413) (#438) (#443)

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored the help text elements displayed when users access the destinations list page after destinations deprecation.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated snapshot.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated button text.

Signed-off-by: AWSHurneyt <[email protected]>

* Updated snapshot files.

Signed-off-by: AWSHurneyt <[email protected]>

* Refactored landing page logic.

Signed-off-by: AWSHurneyt <[email protected]>

Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 58dee83)

Co-authored-by: AWSHurneyt <[email protected]>

Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>

* Fix CVE-2022-46175 (#453)

Signed-off-by: bowenlan-amzn <[email protected]>

Signed-off-by: bowenlan-amzn <[email protected]>

* Updated MAINTAINERS.md to match recommended opensearch-project format. (#435)

Signed-off-by: dblock <[email protected]>

Signed-off-by: dblock <[email protected]>

* Refactored cypress and unit test workflows to use the 2.5.0 tag as the OSD repo reference. (#462)

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Kaituo Li <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Aleksandar Djindjic <[email protected]>
Signed-off-by: Saurabh Singh <[email protected]>
Signed-off-by: bowenlan-amzn <[email protected]>
Signed-off-by: dblock <[email protected]>
Co-authored-by: AWSHurneyt <[email protected]>
Co-authored-by: Kaituo Li <[email protected]>
Co-authored-by: Amardeepsingh Siglani <[email protected]>
Co-authored-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: Aleksandar Djindjic <[email protected]>
Co-authored-by: Saurabh Singh <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: bowenlan-amzn <[email protected]>
Co-authored-by: Daniel (dB.) Doubrovkine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Alert details flyout's responsiveness
5 participants